You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/06/15 14:59:01 UTC
[GitHub] [tvm] kparzysz-quic opened a new pull request, #11731: [MetaSchedule] Include te/tensor.h instead of forward declaring te::T…
kparzysz-quic opened a new pull request, #11731:
URL: https://github.com/apache/tvm/pull/11731
…ensor
`ApplyHistoryBestNode` declares an `Array` of `Tensor`. There are type traits used in `Array` that require that the element type is complete at the time of the declaration. With only a forward declaration compilation fails (clang 14.0.3, libc++).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] kparzysz-quic commented on pull request #11731: [MetaSchedule] Include te/tensor.h instead of forward declaring te::T…
Posted by GitBox <gi...@apache.org>.
kparzysz-quic commented on PR #11731:
URL: https://github.com/apache/tvm/pull/11731#issuecomment-1156761665
It's actually a good practice to use forward declarations when the header is not needed. The problem is that in some cases the types must me complete, in this case it was because there was `std::enable_if` used in the declaration of `Array`. The trait checked in there required the checked type to be complete.
What I find surprising that it works with the compilers we use in CI. I'm not sure of this is because of newer clang, or because I'm using libc++.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #11731: [MetaSchedule] Include te/tensor.h instead of forward declaring te::T…
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on PR #11731:
URL: https://github.com/apache/tvm/pull/11731#issuecomment-1156752309
Lesson learned here for me is that never do forward declaration if we can simply include a header :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 merged pull request #11731: [MetaSchedule] Include te/tensor.h instead of forward declaring te::T…
Posted by GitBox <gi...@apache.org>.
junrushao1994 merged PR #11731:
URL: https://github.com/apache/tvm/pull/11731
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] kparzysz-quic commented on pull request #11731: [MetaSchedule] Include te/tensor.h instead of forward declaring te::T…
Posted by GitBox <gi...@apache.org>.
kparzysz-quic commented on PR #11731:
URL: https://github.com/apache/tvm/pull/11731#issuecomment-1156863403
Try setting `-DCMAKE_CXX_FLAGS='-stdlib=libc++'`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #11731: [MetaSchedule] Include te/tensor.h instead of forward declaring te::T…
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on PR #11731:
URL: https://github.com/apache/tvm/pull/11731#issuecomment-1156851496
@kparzysz-quic Yeah I just verified with clang 14:
```
>>> clang++-14 --version
Ubuntu clang version 14.0.5-++20220603124341+2f0a69c32a4c-1~exp1~20220603124352.149
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/bin
```
but yet cannot reproduce the compilation issue...so i guess probably it's something with libc++
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org