You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "orionlibs (via GitHub)" <gi...@apache.org> on 2023/07/16 01:31:35 UTC
[GitHub] [commons-exec] orionlibs opened a new pull request, #112: EXEC-105: fixed documentation
orionlibs opened a new pull request, #112:
URL: https://github.com/apache/commons-exec/pull/112
[EXEC-105](https://issues.apache.org/jira/browse/EXEC-105): fixed documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-exec] garydgregory commented on a diff in pull request #112: EXEC-105: fixed documentation
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on code in PR #112:
URL: https://github.com/apache/commons-exec/pull/112#discussion_r1264685302
##########
src/site/apt/tutorial.apt:
##########
@@ -169,7 +169,7 @@ executor.execute(cmdLine, resultHandler);
// some time later the result handler callback was invoked so we
// can safely request the exit value
-int exitValue = resultHandler.waitFor();
+resultHandler.waitFor();
Review Comment:
In general, don't update changes.xml, if every PR did that, they would all create merge problems. Note that "dev" is for Apache IDs and "due-to" is for contributor IDs that can be tied so _something_, like a GitHub account.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-exec] garydgregory commented on a diff in pull request #112: EXEC-105: fixed documentation
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on code in PR #112:
URL: https://github.com/apache/commons-exec/pull/112#discussion_r1264685302
##########
src/site/apt/tutorial.apt:
##########
@@ -169,7 +169,7 @@ executor.execute(cmdLine, resultHandler);
// some time later the result handler callback was invoked so we
// can safely request the exit value
-int exitValue = resultHandler.waitFor();
+resultHandler.waitFor();
Review Comment:
In general, don't update changes.xml, if every PR did that, they would all create merge problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-exec] ecki commented on a diff in pull request #112: EXEC-105: fixed documentation
Posted by "ecki (via GitHub)" <gi...@apache.org>.
ecki commented on code in PR #112:
URL: https://github.com/apache/commons-exec/pull/112#discussion_r1264679931
##########
src/site/apt/tutorial.apt:
##########
@@ -169,7 +169,7 @@ executor.execute(cmdLine, resultHandler);
// some time later the result handler callback was invoked so we
// can safely request the exit value
-int exitValue = resultHandler.waitFor();
+resultHandler.waitFor();
Review Comment:
Looks good - maybe in the future we should use snippets or at least have a copy in a test class.
you might need to add the changes.xml entry?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-exec] orionlibs commented on a diff in pull request #112: EXEC-105: fixed documentation
Posted by "orionlibs (via GitHub)" <gi...@apache.org>.
orionlibs commented on code in PR #112:
URL: https://github.com/apache/commons-exec/pull/112#discussion_r1264682493
##########
src/site/apt/tutorial.apt:
##########
@@ -169,7 +169,7 @@ executor.execute(cmdLine, resultHandler);
// some time later the result handler callback was invoked so we
// can safely request the exit value
-int exitValue = resultHandler.waitFor();
+resultHandler.waitFor();
Review Comment:
@ecki updated changes.xml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-exec] ecki commented on a diff in pull request #112: EXEC-105: fixed documentation
Posted by "ecki (via GitHub)" <gi...@apache.org>.
ecki commented on code in PR #112:
URL: https://github.com/apache/commons-exec/pull/112#discussion_r1264625159
##########
src/site/apt/tutorial.apt:
##########
@@ -169,7 +169,7 @@ executor.execute(cmdLine, resultHandler);
// some time later the result handler callback was invoked so we
// can safely request the exit value
-int exitValue = resultHandler.waitFor();
+resultHandler.waitFor();
Review Comment:
I would also show the exitValue = resultHandler.getExitValue(); call as the comment suggests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-exec] garydgregory commented on a diff in pull request #112: EXEC-105: fixed documentation
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on code in PR #112:
URL: https://github.com/apache/commons-exec/pull/112#discussion_r1264670462
##########
src/site/apt/tutorial.apt:
##########
@@ -169,7 +169,7 @@ executor.execute(cmdLine, resultHandler);
// some time later the result handler callback was invoked so we
// can safely request the exit value
-int exitValue = resultHandler.waitFor();
+resultHandler.waitFor();
Review Comment:
Hi @ecki,
Does the PR look ok to you now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-exec] garydgregory merged pull request #112: EXEC-105: fix documentation
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory merged PR #112:
URL: https://github.com/apache/commons-exec/pull/112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org