You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Hao Hao (Code Review)" <ge...@cloudera.org> on 2017/03/07 21:46:15 UTC
[kudu-CR] Fix Webserver option 'password file' to pass correct Squeasel option 'global auth file' for enabling HTTP authorization.
Hao Hao has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6300
Change subject: Fix Webserver option 'password_file' to pass correct Squeasel option 'global_auth_file' for enabling HTTP authorization.
......................................................................
Fix Webserver option 'password_file' to pass correct Squeasel option
'global_auth_file' for enabling HTTP authorization.
Also add test case for web UI .htpasswd support.
Change-Id: I2d30f450abfb3d0addc0eef39bcf78c87e4298c5
---
M src/kudu/security/CMakeLists.txt
A src/kudu/security/test/test_pass.cc
A src/kudu/security/test/test_pass.h
M src/kudu/server/webserver-test.cc
M src/kudu/server/webserver.cc
5 files changed, 96 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/6300/1
--
To view, visit http://gerrit.cloudera.org:8080/6300
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2d30f450abfb3d0addc0eef39bcf78c87e4298c5
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
[kudu-CR] Fix Webserver option 'password file' to pass correct Squeasel option 'global auth file' for enabling HTTP authorization.
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6300
to look at the new patch set (#3).
Change subject: Fix Webserver option 'password_file' to pass correct Squeasel option 'global_auth_file' for enabling HTTP authorization.
......................................................................
Fix Webserver option 'password_file' to pass correct Squeasel option
'global_auth_file' for enabling HTTP authorization.
Also add test case for web UI .htpasswd support.
Change-Id: I2d30f450abfb3d0addc0eef39bcf78c87e4298c5
---
M src/kudu/security/CMakeLists.txt
A src/kudu/security/test/test_pass.cc
A src/kudu/security/test/test_pass.h
M src/kudu/server/webserver-test.cc
M src/kudu/server/webserver.cc
5 files changed, 96 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/6300/3
--
To view, visit http://gerrit.cloudera.org:8080/6300
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2d30f450abfb3d0addc0eef39bcf78c87e4298c5
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
[kudu-CR] Fix Webserver option 'password file' to pass correct Squeasel option 'global auth file' for enabling HTTP authorization.
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change.
Change subject: Fix Webserver option 'password_file' to pass correct Squeasel option 'global_auth_file' for enabling HTTP authorization.
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/6300/3/src/kudu/server/webserver-test.cc
File src/kudu/server/webserver-test.cc:
Line 113: Status status = curl_.FetchURL(strings::Substitute("http://$0/", addr_.ToString()),
> Is there a way to test the success case? I'm not familiar enough with curl
I tried to do a success case. I followed the curl man here: https://curl.haxx.se/docs/manual.html. To fetch with url in the format "username:passwd@machine.domain:port/". However always returned 401 error. So I tried manual testing, it is working. Wondering if the way I am using curl is still wrong?
http://gerrit.cloudera.org:8080/#/c/6300/3/src/kudu/server/webserver.cc
File src/kudu/server/webserver.cc:
PS3, Line 195: opts_.password_file;
: options.push_back("global_auth_file");
> Should we change all instances of "password_file" to "auth_file"?
I feel those two are kind of interchangeable. "Password" may even be more accurate as it is storing username:password. Does that make sense?
--
To view, visit http://gerrit.cloudera.org:8080/6300
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d30f450abfb3d0addc0eef39bcf78c87e4298c5
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Fix Webserver option 'password file' to pass correct Squeasel option 'global auth file' for enabling HTTP authorization.
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: Fix Webserver option 'password_file' to pass correct Squeasel option 'global_auth_file' for enabling HTTP authorization.
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6300
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d30f450abfb3d0addc0eef39bcf78c87e4298c5
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Fix Webserver option 'password file' to pass correct Squeasel option 'global auth file' for enabling HTTP authorization.
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change.
Change subject: Fix Webserver option 'password_file' to pass correct Squeasel option 'global_auth_file' for enabling HTTP authorization.
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/6300/1/src/kudu/security/test/test_pass.cc
File src/kudu/security/test/test_pass.cc:
Line 39: }
> warning: namespace 'security' not terminated with a closing comment [google
Done
Line 40: }
> warning: namespace 'kudu' not terminated with a closing comment [google-rea
Done
--
To view, visit http://gerrit.cloudera.org:8080/6300
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d30f450abfb3d0addc0eef39bcf78c87e4298c5
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: Yes
[kudu-CR] Fix Webserver option 'password file' to pass correct Squeasel option 'global auth file' for enabling HTTP authorization.
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.
Change subject: Fix Webserver option 'password_file' to pass correct Squeasel option 'global_auth_file' for enabling HTTP authorization.
......................................................................
Fix Webserver option 'password_file' to pass correct Squeasel option
'global_auth_file' for enabling HTTP authorization.
Also add test case for web UI .htpasswd support.
Change-Id: I2d30f450abfb3d0addc0eef39bcf78c87e4298c5
Reviewed-on: http://gerrit.cloudera.org:8080/6300
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert <da...@apache.org>
---
M src/kudu/security/CMakeLists.txt
A src/kudu/security/test/test_pass.cc
A src/kudu/security/test/test_pass.h
M src/kudu/server/webserver-test.cc
M src/kudu/server/webserver.cc
5 files changed, 96 insertions(+), 2 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6300
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2d30f450abfb3d0addc0eef39bcf78c87e4298c5
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Fix Webserver option 'password file' to pass correct Squeasel option 'global auth file' for enabling HTTP authorization.
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: Fix Webserver option 'password_file' to pass correct Squeasel option 'global_auth_file' for enabling HTTP authorization.
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6300/3/src/kudu/server/webserver-test.cc
File src/kudu/server/webserver-test.cc:
Line 113: Status status = curl_.FetchURL(strings::Substitute("http://$0/", addr_.ToString()),
Is there a way to test the success case? I'm not familiar enough with curl to know if it allows providing a username/password.
--
To view, visit http://gerrit.cloudera.org:8080/6300
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d30f450abfb3d0addc0eef39bcf78c87e4298c5
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Fix Webserver option 'password file' to pass correct Squeasel option 'global auth file' for enabling HTTP authorization.
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change.
Change subject: Fix Webserver option 'password_file' to pass correct Squeasel option 'global_auth_file' for enabling HTTP authorization.
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6300/3/src/kudu/server/webserver.cc
File src/kudu/server/webserver.cc:
PS3, Line 195: opts_.password_file;
: options.push_back("global_auth_file");
Should we change all instances of "password_file" to "auth_file"?
--
To view, visit http://gerrit.cloudera.org:8080/6300
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d30f450abfb3d0addc0eef39bcf78c87e4298c5
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] Fix Webserver option 'password file' to pass correct Squeasel option 'global auth file' for enabling HTTP authorization.
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has uploaded a new patch set (#2).
Change subject: Fix Webserver option 'password_file' to pass correct Squeasel option 'global_auth_file' for enabling HTTP authorization.
......................................................................
Fix Webserver option 'password_file' to pass correct Squeasel option
'global_auth_file' for enabling HTTP authorization.
Also add test case for web UI .htpasswd support.
Change-Id: I2d30f450abfb3d0addc0eef39bcf78c87e4298c5
---
M src/kudu/security/CMakeLists.txt
A src/kudu/security/test/test_pass.cc
A src/kudu/security/test/test_pass.h
M src/kudu/server/webserver-test.cc
M src/kudu/server/webserver.cc
5 files changed, 96 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/6300/2
--
To view, visit http://gerrit.cloudera.org:8080/6300
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2d30f450abfb3d0addc0eef39bcf78c87e4298c5
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot