You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/10 14:59:59 UTC

[GitHub] [airflow] bbovenzi opened a new pull request, #25646: Clean up datasets UI and copy

bbovenzi opened a new pull request, #25646:
URL: https://github.com/apache/airflow/pull/25646

   - Remove all references to "upstream" or "downstream" dataset events
   - Remove displaying dataset `extra`
   - In datasets list, remove sorts for task/dag columns
   - In datasets list, add a link to dataset docs when there are no datasets found.
   - Make `getMetaValue` return empty string instead of null by default. We had to do this a ton, so the function itself should handle it.
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] bbovenzi merged pull request #25646: Clean up datasets UI and copy

Posted by GitBox <gi...@apache.org>.
bbovenzi merged PR #25646:
URL: https://github.com/apache/airflow/pull/25646


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] bbovenzi commented on pull request #25646: Clean up datasets UI and copy

Posted by GitBox <gi...@apache.org>.
bbovenzi commented on PR #25646:
URL: https://github.com/apache/airflow/pull/25646#issuecomment-1210910980

   > > Remove all references to "upstream" or "downstream" dataset events
   > 
   > Oh I hadn't realised that you can have up and downstream in the same dagrun.
   > 
   > What does it look like now please?
   
   One is on the dag run details. the other is on the task instance details.
   
   <img width="728" alt="Screen Shot 2022-08-10 at 11 58 19 AM" src="https://user-images.githubusercontent.com/4600967/183956590-852843b0-0349-46db-9de6-2e751735eb81.png">
   
   <img width="702" alt="Screen Shot 2022-08-10 at 11 58 16 AM" src="https://user-images.githubusercontent.com/4600967/183956700-f15ff658-a9fe-47f6-9831-c0c0b54bb112.png">
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] ashb commented on pull request #25646: Clean up datasets UI and copy

Posted by GitBox <gi...@apache.org>.
ashb commented on PR #25646:
URL: https://github.com/apache/airflow/pull/25646#issuecomment-1210871322

   > Remove all references to "upstream" or "downstream" dataset events
   
   Oh I hadn't realised that you can have up and downstream in the same dagrun.
   
   What does it look like now please?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] ashb commented on pull request #25646: Clean up datasets UI and copy

Posted by GitBox <gi...@apache.org>.
ashb commented on PR #25646:
URL: https://github.com/apache/airflow/pull/25646#issuecomment-1210922615

   > One is on the dag run details. the other is on the task instance details.
   
   Oh cool, that's alright then.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org