You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/11/15 01:46:31 UTC

[GitHub] [cloudstack] GutoVeronezi opened a new pull request, #6900: Fix ping NFS server on ssvm-check.sh

GutoVeronezi opened a new pull request, #6900:
URL: https://github.com/apache/cloudstack/pull/6900

   ### Description
   
   Part of script `ssvm-check.sh` checks if the secondary storage is mounted on the SSVM. If it is not mounted, it tries to ping the "NFS server"; This process infers that the "NFS server" is the seventeenth element of file `/var/cache/cloud/cmdline`; however, the index of the elements can vary according to some configurations (vide `SecondaryStorageManagerImpl#finalizeVirtualMachineProfile`). For instance, in https://github.com/apache/cloudstack/pull/6348#issuecomment-1310020312 it is trying to ping the netmask. Futhermore, we do not have the information of the NSF server in the `/var/cache/cloud/cmdline` file.
   
   This PR intends to fix the check by adding the secondary storage server address to the file and retrieving it by the name. If the property is not in the file, it tries to validate the storage gateway to mitigate the "storage not mounted" situation.
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [ ] Critical
   - [ ] Major
   - [x] Minor
   - [ ] Trivial
   
   
   ### How Has This Been Tested?
   ...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] GutoVeronezi commented on pull request #6900: Fix ping NFS server on ssvm-check.sh

Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on PR #6900:
URL: https://github.com/apache/cloudstack/pull/6900#issuecomment-1317016218

   @DaanHoogland, I think this fix could help in the #6348 troubleshooting. I will do more manual tests and add some unit tests before putting this as ready.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] github-actions[bot] commented on pull request #6900: Fix ping NFS server on ssvm-check.sh

Posted by github-actions.
github-actions[bot] commented on PR #6900:
URL: https://github.com/apache/cloudstack/pull/6900#issuecomment-1410017160

   This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] GutoVeronezi commented on pull request #6900: Fix ping NFS server on ssvm-check.sh

Posted by "GutoVeronezi (via GitHub)" <gi...@apache.org>.
GutoVeronezi commented on PR #6900:
URL: https://github.com/apache/cloudstack/pull/6900#issuecomment-1413571428

   @DaanHoogland @weizhouapache
   I created issue #7162.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6900: Fix ping NFS server on ssvm-check.sh

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #6900:
URL: https://github.com/apache/cloudstack/pull/6900#discussion_r1092078869


##########
services/secondary-storage/controller/src/main/java/org/apache/cloudstack/secondarystorage/SecondaryStorageManagerImpl.java:
##########
@@ -1180,9 +1182,29 @@ public boolean finalizeVirtualMachineProfile(VirtualMachineProfile profile, Depl
         s_logger.debug(String.format("Setting UseHttpsToUpload config on cmdline with [%s] value.", useHttpsToUpload));
         buf.append(" useHttpsToUpload=").append(useHttpsToUpload);
 
+        addSecondaryStorageServerAddressToBuffer(buf, secStore, vmName);

Review Comment:
   @weizhouapache @GutoVeronezi , though I think Wei's request is valid it seems to me to be out of scope for this PR and the issue it tries to solve . Shall we move this enhancement to a new PR?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] GutoVeronezi commented on pull request #6900: Fix ping NFS server on ssvm-check.sh

Posted by "GutoVeronezi (via GitHub)" <gi...@apache.org>.
GutoVeronezi commented on PR #6900:
URL: https://github.com/apache/cloudstack/pull/6900#issuecomment-1412686269

   @DaanHoogland, here follows the tests:
   
   I recreated the SSVM:
   ```
   2023-02-01 15:46:27,304 DEBUG [o.a.c.s.SecondaryStorageManagerImpl] (Work-Job-Executor-3:ctx-f0e60658 job-1060/job-1065 ctx-066f71f0) (logid:b55ecf19) Found [nfs://192.168.30.140/mnt/secondary-storage] as secondary storage's URL for SSVM [s-216-VM].
   2023-02-01 15:46:27,304 INFO  [o.a.c.s.SecondaryStorageManagerImpl] (Work-Job-Executor-3:ctx-f0e60658 job-1060/job-1065 ctx-066f71f0) (logid:b55ecf19) Using [192.168.30.140] as address of secondary storage of SSVM [s-216-VM].
   ```
   
   Then, I verified the content of `/var/cache/cloud/cmdline`
   ```
   root@s-216-VM:~# cat /var/cache/cloud/cmdline
   template=domP type=secstorage host=192.168.202.150,192.168.202.151 port=8250 name=s-216-VM zone=1 pod=1 guid=s-216-VM workers=5 authorized_key=c3NoLXJzYSBBQUFBQjNOemFDMXljMkVBQUFBREFRQUJBQUFCZ1FETC9OVmNPZnRVNU9WMHIyYmNxV2tUOXdySTdOV3pHTnM4Y3UzaTFWaWszbzJESUoyM284cWFHaUtLZHRlMDdTdDBVRnU5TUlBdFlxZ05kVzJnNXNzS2puaU84QVZKMFUrZ1o5bGdYUS9NaTRDT1lTNDhuQzNJaFhBUW14SlZCNDR4V2FtemhmNHBCNndIaDJqeFFCSUFLVTBVelNWWFd6SmtXYjA3M0ZFUUdraDJlV2F6YXN4ZVVsQmFRcDNNUnFla3Jmdks1WHFOVERUdGI1YUpNZTFqOUl3Yk84b0VtcmpyVnZDZnlvaXo3Wi9FTnlkaVl4TXlxdHlCei9pSW11dGQ0YXlET1JQYjNyaGVwUGZCMkJvdFFIRGtsMDN1UzdEMjVPZ21EaVZweVdzalhKY2lSeEorWm53SDdFR0tMejBMbnN4QUlkVitwZ3FzTVE4ZmhNcUYybkx2TFlwejZvYWlTUnRGTlEyUERqZU9aRVAzeGRUUDkwbXpzUmpteGhaZ2JBU3pRUE5lRWYwZ1RmeXFmTjIrUThZYkFyWmhLRDJUeDFPQ2hmTFRPbUNBUkNjbjFRUmkrV29BUmhoVkZmNmhCeU9xalZXdEZVblR4L0NCaDBMdjVyNU5aK0ZIelNLRDJVYjJ0NXVhWDVXaFo4Ym1LT3JPNDh2NDVjd1dTYzA9IGNsb3VkQGNsb3Vkc3RhY2stbGFiLW1hbmFnZW1lbnQtMQo= resource=com.cloud.storage.resource.PremiumSecondaryStorageResource
  instance=SecStorage sslcopy=false role=templateProcessor mtu=1500 eth2ip=172.16.200.100 eth2mask=255.255.255.0 gateway=172.16.200.1 public.network.device=eth2 eth0ip=169.254.238.235 eth0mask=255.255.0.0 eth1ip=192.168.202.86 eth1mask=255.255.255.0 mgmtcidr=172.16.200.0/24 localgw=192.168.202.1 private.network.device=eth1 eth3ip=192.168.30.86 eth3mask=255.255.255.0 storageip=192.168.30.86 storagenetmask=255.255.255.0 storagegateway=192.168.30.1 internaldns1=8.8.8.8 dns1=8.8.8.8 dns2=8.8.4.4 nfsVersion=null keystore_password=czQ0aXNGUXZwa1J2N2FuNg== useHttpsToUpload=true secondaryStorageServerAddress=192.168.30.140
   ```
   
   To test the script, I stopped the service `cloud`, unmounted the storage, and executed the script:
   
   ```
   root@s-216-VM:~# systemctl stop cloud
   root@s-216-VM:~# umount /mnt/SecStorage/e265f9ca-e368-313d-8ccc-7a4c4a1adc41
   root@s-216-VM:~# /usr/local/cloud/systemvm/ssvm-check.sh
   ================================================
   First DNS server is  8.8.8.8
   PING 8.8.8.8 (8.8.8.8): 56 data bytes
   --- 8.8.8.8 ping statistics ---
   2 packets transmitted, 0 packets received, 100% packet loss
   WARNING: cannot ping DNS server
   route follows
   Kernel IP routing table
   Destination     Gateway         Genmask         Flags Metric Ref    Use Iface
   0.0.0.0         172.16.200.1    0.0.0.0         UG    0      0        0 eth2
   8.8.8.8         192.168.202.1   255.255.255.255 UGH   0      0        0 eth1
   169.254.0.0     0.0.0.0         255.255.0.0     U     0      0        0 eth0
   172.16.200.0    0.0.0.0         255.255.255.0   U     0      0        0 eth2
   192.168.30.0    0.0.0.0         255.255.255.0   U     0      0        0 eth3
   192.168.202.0   0.0.0.0         255.255.255.0   U     0      0        0 eth1
   ================================================
   Good: DNS resolves cloudstack.apache.org
   ================================================
   ERROR: Storage nfs is not currently mounted
   Verifying if we can at least ping the storage
   Storage address is 192.168.30.140, trying to ping it
   PING 192.168.30.140 (192.168.30.140): 56 data bytes
   64 bytes from 192.168.30.140: icmp_seq=0 ttl=64 time=1.720 ms
   64 bytes from 192.168.30.140: icmp_seq=1 ttl=64 time=2.342 ms
   --- 192.168.30.140 ping statistics ---
   2 packets transmitted, 2 packets received, 0% packet loss
   round-trip min/avg/max/stddev = 1.720/2.031/2.342/0.311 ms
   Good: Can ping nfs storage address
   ================================================
   Management server is 192.168.202.150,192.168.202.151. Checking connectivity.
   2023/02/01 20:19:12 socat[5764] E write(5, 0x55c330088000, 1): Connection refused
   Good: Can connect to management server 192.168.202.150 port 8250
   2023/02/01 20:19:15 socat[5768] E connecting to AF=2 192.168.202.151:8250: Connection timed out
   Good: Can connect to management server 192.168.202.151 port 8250
   ================================================
   ERROR: Java process not running.  Try restarting the SSVM.
   ```
   
   Then, I repeated the test removing `secondaryStorageServerAddress` from `/var/cache/cloud/cmdline`:
   
   ```
   root@s-216-VM:~# /usr/local/cloud/systemvm/ssvm-check.sh
   ================================================
   First DNS server is  8.8.8.8
   PING 8.8.8.8 (8.8.8.8): 56 data bytes
   --- 8.8.8.8 ping statistics ---
   2 packets transmitted, 0 packets received, 100% packet loss
   WARNING: cannot ping DNS server
   route follows
   Kernel IP routing table
   Destination     Gateway         Genmask         Flags Metric Ref    Use Iface
   0.0.0.0         172.16.200.1    0.0.0.0         UG    0      0        0 eth2
   8.8.8.8         192.168.202.1   255.255.255.255 UGH   0      0        0 eth1
   169.254.0.0     0.0.0.0         255.255.0.0     U     0      0        0 eth0
   172.16.200.0    0.0.0.0         255.255.255.0   U     0      0        0 eth2
   192.168.30.0    0.0.0.0         255.255.255.0   U     0      0        0 eth3
   192.168.202.0   0.0.0.0         255.255.255.0   U     0      0        0 eth1
   ================================================
   Good: DNS resolves cloudstack.apache.org
   ================================================
   ERROR: Storage nfs is not currently mounted
   Verifying if we can at least ping the storage
   Storage address is empty, trying to ping storage network gateway instead (192.168.30.1)
   PING 192.168.30.1 (192.168.30.1): 56 data bytes
   64 bytes from 192.168.30.1: icmp_seq=0 ttl=64 time=3.980 ms
   64 bytes from 192.168.30.1: icmp_seq=1 ttl=64 time=1.264 ms
   --- 192.168.30.1 ping statistics ---
   2 packets transmitted, 2 packets received, 0% packet loss
   round-trip min/avg/max/stddev = 1.264/2.622/3.980/1.358 ms
   Good: Can ping nfs storage network gateway
   ================================================
   Management server is 192.168.202.150,192.168.202.151. Checking connectivity.
   2023/02/01 20:22:54 socat[6030] E write(5, 0x55c336b75000, 1): Connection refused
   Good: Can connect to management server 192.168.202.150 port 8250
   2023/02/01 20:22:57 socat[6034] E connecting to AF=2 192.168.202.151:8250: Connection timed out
   Good: Can connect to management server 192.168.202.151 port 8250
   ================================================
   ERROR: Java process not running.  Try restarting the SSVM.
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] GutoVeronezi commented on a diff in pull request #6900: Fix ping NFS server on ssvm-check.sh

Posted by "GutoVeronezi (via GitHub)" <gi...@apache.org>.
GutoVeronezi commented on code in PR #6900:
URL: https://github.com/apache/cloudstack/pull/6900#discussion_r1091853042


##########
services/secondary-storage/controller/src/main/java/org/apache/cloudstack/secondarystorage/SecondaryStorageManagerImpl.java:
##########
@@ -1180,9 +1182,29 @@ public boolean finalizeVirtualMachineProfile(VirtualMachineProfile profile, Depl
         s_logger.debug(String.format("Setting UseHttpsToUpload config on cmdline with [%s] value.", useHttpsToUpload));
         buf.append(" useHttpsToUpload=").append(useHttpsToUpload);
 
+        addSecondaryStorageServerAddressToBuffer(buf, secStore, vmName);

Review Comment:
   Sure, I'll take a look at this today.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #6900: Fix ping NFS server on ssvm-check.sh

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #6900:
URL: https://github.com/apache/cloudstack/pull/6900#issuecomment-1410040246

   @GutoVeronezi you have conflicts :(


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] codecov[bot] commented on pull request #6900: Fix ping NFS server on ssvm-check.sh

Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #6900:
URL: https://github.com/apache/cloudstack/pull/6900#issuecomment-1314727893

   # [Codecov](https://codecov.io/gh/apache/cloudstack/pull/6900?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#6900](https://codecov.io/gh/apache/cloudstack/pull/6900?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (382e521) into [main](https://codecov.io/gh/apache/cloudstack/commit/c5e657ddd80faa93585aef1381e30b7e2d9a9eaa?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c5e657d) will **decrease** coverage by `0.00%`.
   > The diff coverage is `0.00%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##               main    #6900      +/-   ##
   ============================================
   - Coverage     10.87%   10.87%   -0.01%     
   + Complexity     7117     7115       -2     
   ============================================
     Files          2485     2485              
     Lines        245507   245519      +12     
     Branches      38334    38335       +1     
   ============================================
   - Hits          26699    26695       -4     
   - Misses       215538   215555      +17     
   + Partials       3270     3269       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/6900?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../secondarystorage/SecondaryStorageManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6900/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmljZXMvc2Vjb25kYXJ5LXN0b3JhZ2UvY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvY2xvdWRzdGFjay9zZWNvbmRhcnlzdG9yYWdlL1NlY29uZGFyeVN0b3JhZ2VNYW5hZ2VySW1wbC5qYXZh) | `4.28% <0.00%> (-0.08%)` | :arrow_down: |
   | [...dstack/network/contrail/model/ModelObjectBase.java](https://codecov.io/gh/apache/cloudstack/pull/6900/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9uZXR3b3JrLWVsZW1lbnRzL2p1bmlwZXItY29udHJhaWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svbmV0d29yay9jb250cmFpbC9tb2RlbC9Nb2RlbE9iamVjdEJhc2UuamF2YQ==) | `21.15% <0.00%> (-7.70%)` | :arrow_down: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #6900: Fix ping NFS server on ssvm-check.sh

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on code in PR #6900:
URL: https://github.com/apache/cloudstack/pull/6900#discussion_r1091781970


##########
services/secondary-storage/controller/src/main/java/org/apache/cloudstack/secondarystorage/SecondaryStorageManagerImpl.java:
##########
@@ -1180,9 +1182,29 @@ public boolean finalizeVirtualMachineProfile(VirtualMachineProfile profile, Depl
         s_logger.debug(String.format("Setting UseHttpsToUpload config on cmdline with [%s] value.", useHttpsToUpload));
         buf.append(" useHttpsToUpload=").append(useHttpsToUpload);
 
+        addSecondaryStorageServerAddressToBuffer(buf, secStore, vmName);

Review Comment:
   @GutoVeronezi 
   can you add the addresses of all image stores ?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] GutoVeronezi commented on a diff in pull request #6900: Fix ping NFS server on ssvm-check.sh

Posted by "GutoVeronezi (via GitHub)" <gi...@apache.org>.
GutoVeronezi commented on code in PR #6900:
URL: https://github.com/apache/cloudstack/pull/6900#discussion_r1092354163


##########
services/secondary-storage/controller/src/main/java/org/apache/cloudstack/secondarystorage/SecondaryStorageManagerImpl.java:
##########
@@ -1180,9 +1182,29 @@ public boolean finalizeVirtualMachineProfile(VirtualMachineProfile profile, Depl
         s_logger.debug(String.format("Setting UseHttpsToUpload config on cmdline with [%s] value.", useHttpsToUpload));
         buf.append(" useHttpsToUpload=").append(useHttpsToUpload);
 
+        addSecondaryStorageServerAddressToBuffer(buf, secStore, vmName);

Review Comment:
   @DaanHoogland, I'm okay with both approaches; however, moving the enhancement to a new PR sounds better, as we could release the fix previously.
   
   I'm doing another round of tests to post the results.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] weizhouapache commented on pull request #6900: Fix ping NFS server on ssvm-check.sh

Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #6900:
URL: https://github.com/apache/cloudstack/pull/6900#issuecomment-1413461636

   @GutoVeronezi 
   can you create an issue for follow-up ? thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland merged pull request #6900: Fix ping NFS server on ssvm-check.sh

Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland merged PR #6900:
URL: https://github.com/apache/cloudstack/pull/6900


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6900: Fix ping NFS server on ssvm-check.sh

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6900:
URL: https://github.com/apache/cloudstack/pull/6900#issuecomment-1314684654

   SonarCloud Quality Gate failed.&nbsp; &nbsp; [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6900)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6900&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6900&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6900&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6900&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6900&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6900&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6900&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6900&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6900&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6900&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6900&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6900&resolved=false&types=CODE_SMELL)
   
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6900&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6900&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6900&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6900&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] DaanHoogland commented on pull request #6900: Fix ping NFS server on ssvm-check.sh

Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6900:
URL: https://github.com/apache/cloudstack/pull/6900#issuecomment-1314917617

   Looks good @GutoVeronezi  (except that I don´t like parameter expansions in debug level mesaages) but
    shouldn´t we apply this on #6348 to help investigate why this PR keeps failing consistently?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6900: Fix ping NFS server on ssvm-check.sh

Posted by sonarcloud.
sonarcloud[bot] commented on PR #6900:
URL: https://github.com/apache/cloudstack/pull/6900#issuecomment-1410276619

   SonarCloud Quality Gate failed.&nbsp; &nbsp; [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6900)
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6900&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6900&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6900&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6900&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6900&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6900&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6900&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6900&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6900&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6900&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6900&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6900&resolved=false&types=CODE_SMELL)
   
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6900&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6900&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6900&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6900&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org