You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by mm...@apache.org on 2005/09/28 23:13:37 UTC
svn commit: r292301 - in /myfaces/api/trunk/src/java/javax/faces/component:
UIInput.java UISelectMany.java
Author: mmarinschek
Date: Wed Sep 28 14:13:31 2005
New Revision: 292301
URL: http://svn.apache.org/viewcvs?rev=292301&view=rev
Log:
Played with JavaScript in renderers, apart from this minor changes.
Modified:
myfaces/api/trunk/src/java/javax/faces/component/UIInput.java
myfaces/api/trunk/src/java/javax/faces/component/UISelectMany.java
Modified: myfaces/api/trunk/src/java/javax/faces/component/UIInput.java
URL: http://svn.apache.org/viewcvs/myfaces/api/trunk/src/java/javax/faces/component/UIInput.java?rev=292301&r1=292300&r2=292301&view=diff
==============================================================================
--- myfaces/api/trunk/src/java/javax/faces/component/UIInput.java (original)
+++ myfaces/api/trunk/src/java/javax/faces/component/UIInput.java Wed Sep 28 14:13:31 2005
@@ -273,7 +273,7 @@
Object previousValue = getValue();
setValue(convertedValue);
setSubmittedValue(null);
- if (compareValues(previousValue, convertedValue))
+ if (valuesDifferent(previousValue, convertedValue))
{
queueEvent(new ValueChangeEvent(this, previousValue, convertedValue));
}
@@ -315,11 +315,10 @@
- protected boolean compareValues(Object previous,
- Object value)
+ protected boolean valuesDifferent(Object previous,
+ Object value)
{
- return !((previous == null && value == null) ||
- (previous != null && value != null && previous.equals(value)));
+ return previous==null?(value!=null):(!previous.equals(value));
}
public void addValidator(Validator validator)
Modified: myfaces/api/trunk/src/java/javax/faces/component/UISelectMany.java
URL: http://svn.apache.org/viewcvs/myfaces/api/trunk/src/java/javax/faces/component/UISelectMany.java?rev=292301&r1=292300&r2=292301&view=diff
==============================================================================
--- myfaces/api/trunk/src/java/javax/faces/component/UISelectMany.java (original)
+++ myfaces/api/trunk/src/java/javax/faces/component/UISelectMany.java Wed Sep 28 14:13:31 2005
@@ -79,7 +79,7 @@
/**
* @return true if Objects are different (!)
*/
- protected boolean compareValues(Object previous, Object value)
+ protected boolean valuesDifferent(Object previous, Object value)
{
if (previous == null)
{