You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@carbondata.apache.org by GitBox <gi...@apache.org> on 2022/07/07 05:29:05 UTC

[GitHub] [carbondata] Indhumathi27 commented on a diff in pull request #4287: [CARBONDATA-4346] Remove list files while query and invalid cache

Indhumathi27 commented on code in PR #4287:
URL: https://github.com/apache/carbondata/pull/4287#discussion_r915472198


##########
integration/spark/src/main/scala/org/apache/spark/sql/execution/command/mutation/CarbonProjectForUpdateCommand.scala:
##########
@@ -190,6 +192,10 @@ private[sql] case class CarbonProjectForUpdateCommand(
             updateTableModel,
             executionErrors)
 
+          // clear invalid segments from cache
+          IndexStoreManager.getInstance()

Review Comment:
   instead of handling this in command class, better move this to `DeleteExecution.deletedeltaexecution` and will be used from both update and delete flow



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org