[GitHub] [samza] mynameborat commented on a change in pull request #1424: SAMZA-2584: Refactor ClusterBasedJobCoordinator

[GitBox <gi...@apache.org>]

mynameborat commented on a change in pull request #1424:
URL: https://github.com/apache/samza/pull/1424#discussion_r482221639



##########
File path: samza-core/src/test/java/org/apache/samza/clustermanager/TestClusterBasedJobCoordinatorRunner.java
##########
@@ -64,15 +64,15 @@
 
 
 /**
- * Tests for {@link ClusterBasedJobCoordinator}
+ * Tests for {@link TestClusterBasedJobCoordinatorRunner}
  */
 @RunWith(PowerMockRunner.class)
 @PrepareForTest({
     CoordinatorStreamUtil.class,
-    ClusterBasedJobCoordinator.class,
+    ClusterBasedJobCoordinatorRunner.class,
     CoordinatorStreamStore.class,
     RemoteJobPlanner.class})
-public class TestClusterBasedJobCoordinator {

Review comment:
       I'd suggest to keep the old name as is since it is indeed testing the functionality of `ClusterBasedJobCoordinator` like startpoint fanout, partition monitor.
   
   If you can create a new test class for `ClusterBasedJobCoordinatorRunner` and then add test for `runClusterBasedJobCoordinator` (rest of the methods are mostly helpers to construct dependencies) that will be great. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org