[GitHub] [arrow-rs] alamb commented on pull request #1326: Implement DictionaryArray support in neq_dyn, lt_dyn, lt_eq_dyn, gt_dyn, gt_eq_dyn

[GitBox <gi...@apache.org>]

alamb commented on pull request #1326:
URL: https://github.com/apache/arrow-rs/pull/1326#issuecomment-1054677800


   Hi @viirya  -- I hope you don't mind but i merged this PR from master and added https://github.com/apache/arrow-rs/pull/1326/commits/219c131bcc7998807ec3e668563e8658747d8117 to silence clippy -- it was claiming
   
   ```
   error: order comparisons between booleans can be simplified
       --> arrow/src/compute/kernels/comparison.rs:2370:68
        |
   2370 |             typed_dict_compares!(left, right, |a, b| a < b, |a, b| a < b)
        |                                                                    ^^^^^ help: try simplifying it as shown: `!a & b`
        |
        = note: `-D clippy::bool-comparison` implied by `-D warnings`
        = help: for further information visit [https://rust-lang.gi](https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison)
   ```
   
   Which is nonsense in my opinion (!a & b) is much less readable than `a < b` and I would expect the code generator to do that transformation anyways if it helps performance.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org