You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/10 02:25:26 UTC

[GitHub] [spark] sadikovi commented on pull request #37293: [SPARK-39872][SQL] Change to use `BytePackerForLong#unpack8Values` with Array input api in `VectorizedDeltaBinaryPackedReader`

sadikovi commented on PR #37293:
URL: https://github.com/apache/spark/pull/37293#issuecomment-1210076523

   I would prefer to not rely on the facts:
   - that ByteBufferInputStream has only one byte buffer
   - that byte buffer is backed by JVM heap.
   
   It would be good if you could revisit this code change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org