You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by mike-jumper <gi...@git.apache.org> on 2017/01/29 07:06:20 UTC
[GitHub] incubator-guacamole-server pull request #56: GUACAMOLE-148: Fix handling of ...
GitHub user mike-jumper opened a pull request:
https://github.com/apache/incubator-guacamole-server/pull/56
GUACAMOLE-148: Fix handling of terminal scroll.
Terminal emulators maintain the scrolling region and the bounds of the terminal separately. Console codes which allow the scrolling region to be redefined facilitate utilities like top, tmux, or screen which must maintain control of what scrolls and what doesn't.
Guacamole handles scrolling improperly, automatically scrolling whenever the cursor exceeds the bounds of the scroll region. This is only correct behavior when the cursor is within the scrolling region. The terminal should not be scrolled *at all* when the cursor is outside the scrolling region. If outside the scrolling region, the cursor should simply be kept within terminal bounds.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mike-jumper/incubator-guacamole-server fix-terminal-scroll
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-guacamole-server/pull/56.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #56
----
commit 073fbe684d7706a97720ac347feace12854bd899
Author: Michael Jumper <mj...@apache.org>
Date: 2017-01-29T05:24:06Z
GUACAMOLE-148: Scroll automatically only when cursor is within scrolling region.
commit 6c1eeb96b0f3feba38ad74b30f933b91f915045a
Author: Michael Jumper <mj...@apache.org>
Date: 2017-01-29T06:48:45Z
GUACAMOLE-148: Move cursor bounds checking to common location (where necessary).
commit b796b2c9339c90f828e5ace129576e12f45ad30e
Author: Michael Jumper <mj...@apache.org>
Date: 2017-01-29T06:51:21Z
GUACAMOLE-148: Clarify that the cursor is expected to potentially exceed the terminal bounds.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-guacamole-server pull request #56: GUACAMOLE-148: Fix handling of ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-guacamole-server/pull/56
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---