You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by tgravescs <gi...@git.apache.org> on 2016/02/10 20:49:07 UTC

[GitHub] spark pull request: [SPARK-11701][SPARK-13054] dynamic allocation ...

Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10951#discussion_r52514248
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala ---
    @@ -1153,7 +1153,16 @@ class DAGScheduler(
         }
     
         if (!stageIdToStage.contains(task.stageId)) {
    -      // Skip all the actions if the stage has been cancelled.
    +      logInfo("skip normal actions as stage cancelled")
    +      // Need to handle tasks coming in late (speculative and jobs killed)
    +      // post a task end event so accounting for things manually tracking tasks work.
    +      // This really should be something other then success since the other speculative task
    +      // finished first.
    --- End diff --
    
    updating now, need to test and then will post updated version.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org