You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "melgenek (via GitHub)" <gi...@apache.org> on 2023/01/21 13:25:00 UTC
[GitHub] [arrow-datafusion] melgenek opened a new pull request, #5013: Sqllogictest: use the same normalization for all tests
melgenek opened a new pull request, #5013:
URL: https://github.com/apache/arrow-datafusion/pull/5013
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #5010.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
This change simplifies the sqllogictest results normalization logic. It is now the same for all test files.
# What changes are included in this PR?
- the sqllogictest tests are updated to use the same normalization all the time
- some test results are adjusted to match the new normalization logic
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
There are Github Actions for both Datafusion and Postgres sqllogictest runners.
# Are there any user-facing changes?
No.
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #5013: Sqllogictest: use the same normalization for all tests
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #5013:
URL: https://github.com/apache/arrow-datafusion/pull/5013
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #5013: Sqllogictest: use the same normalization for all tests
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #5013:
URL: https://github.com/apache/arrow-datafusion/pull/5013#issuecomment-1400208252
Benchmark runs are scheduled for baseline = 407caad40ec7f8f40372275c1978d3414c6bb82d and contender = 8dc4c96075f20240935f298c6e909f76dcb9a8c3. 8dc4c96075f20240935f298c6e909f76dcb9a8c3 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/a164b994b79c4c5eb13aad45074cfaf1...478b0e782a684389a9430a1cf066c05b/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/1b24daad01b34af39a32622e9aa08275...4b81d7b5a5e64296a4ffb7a313c6d71c/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/4b7312fff7234c888ca6a66648ff00b6...31fdc21ac7af46bb8aac5531f0518140/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/5b26040ef54c438cac01c5b0b1454337...33f4784824c648c1903174e0c07bed40/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5013: Sqllogictest: use the same normalization for all tests
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #5013:
URL: https://github.com/apache/arrow-datafusion/pull/5013#discussion_r1083439436
##########
datafusion/core/tests/sqllogictests/test_files/aggregate.slt:
##########
@@ -22,19 +22,19 @@
query R
SELECT avg(c12) FROM aggregate_test_100
----
-0.5089725099127211
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #5013: Sqllogictest: use the same normalization for all tests
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5013:
URL: https://github.com/apache/arrow-datafusion/pull/5013#issuecomment-1400202708
Thanks again @melgenek -- these improvements are really nice
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org