[GitHub] peng-yongsheng commented on a change in pull request #1904: Extend StorageEntity annotation to support source scope metadata

[GitBox <gi...@apache.org>]

peng-yongsheng commented on a change in pull request #1904: Extend StorageEntity annotation to support source scope metadata
URL: https://github.com/apache/incubator-skywalking/pull/1904#discussion_r232542118
 
 

 ##########
 File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/generated/endpoint/EndpointAvgIndicator.java
 ##########
 @@ -37,10 +38,10 @@
  */
 @IndicatorType
 @StreamData
-@StorageEntity(name = "endpoint_avg", builder = EndpointAvgIndicator.Builder.class)
+@StorageEntity(name = "endpoint_avg", builder = EndpointAvgIndicator.Builder.class, source = Scope.Endpoint)
 public class EndpointAvgIndicator extends LongAvgIndicator implements AlarmSupported {
 
-    @Setter @Getter @Column(columnName = "entity_id") @IDColumn private String entityId;
+    @Setter @Getter @Column(columnName = "entity_id") @IDColumn private java.lang.String entityId;
 
 Review comment:
   Why import the full package for the String object?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services