You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by ad...@apache.org on 2013/10/03 19:45:34 UTC

git commit: WICKET-5378 AutoCompleteTextField inside a ModalWindow shows auto complete dropdown in the wrong location WICKET-5379 IE7: AutoCompleteTextField inside a ModalWindow shows auto complete dropdown behind ModalWindow WICKET-5382 AutoComplete Jav

Updated Branches:
  refs/heads/master f657a6906 -> 0ac535923


WICKET-5378 AutoCompleteTextField inside a ModalWindow shows auto
complete dropdown in the wrong location
WICKET-5379 IE7: AutoCompleteTextField inside a ModalWindow shows auto
complete dropdown behind ModalWindow
WICKET-5382 AutoComplete JavaScript errors

Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/0ac53592
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/0ac53592
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/0ac53592

Branch: refs/heads/master
Commit: 0ac5359230e129ec915532d00fa0ac6a1608bdfc
Parents: f657a69
Author: bitstorm <an...@gmail.com>
Authored: Thu Oct 3 19:45:20 2013 +0200
Committer: bitstorm <an...@gmail.com>
Committed: Thu Oct 3 19:45:20 2013 +0200

----------------------------------------------------------------------
 .../html/autocomplete/wicket-autocomplete.js      | 18 +++---------------
 1 file changed, 3 insertions(+), 15 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/wicket/blob/0ac53592/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js
----------------------------------------------------------------------
diff --git a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js
index d465e1f..ae1ec15 100644
--- a/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js
+++ b/wicket-extensions/src/main/java/org/apache/wicket/extensions/ajax/markup/html/autocomplete/wicket-autocomplete.js
@@ -451,6 +451,9 @@
 			visible = 0;
 			setSelected(-1);
 			ignoreFocus = false;
+			//WICKET-5382
+			hideIndicator();
+			
 			var container = getAutocompleteContainer();
 			if (container)
 			{
@@ -582,21 +585,6 @@
 				leftPosition += obj.clientLeft || 0;
 			}
 
-			obj = obj.offsetParent;
-			while (obj && obj !== document.documentElement && obj !== document.body) {
-				topPosition += obj.offsetTop || 0;
-				topPosition -= obj.scrollTop || 0;
-				if (!cfg.ignoreBordersWhenPositioning) {
-					topPosition += obj.clientTop || 0;
-				}
-				leftPosition += obj.offsetLeft || 0;
-				leftPosition -= obj.scrollLeft || 0;
-				if (!cfg.ignoreBordersWhenPositioning) {
-					leftPosition += obj.clientLeft || 0;
-				}
-				obj = obj.offsetParent;
-			}
-
 			return [leftPosition,topPosition];
 		}