You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2023/01/17 10:59:53 UTC

[GitHub] [incubator-seatunnel] wfrong commented on pull request #3896: [Improve][SourceConnector] Unified schema parameter, update IoTDB sou…

wfrong commented on PR #3896:
URL: https://github.com/apache/incubator-seatunnel/pull/3896#issuecomment-1385245942

   
   
   
   > > > > > LGTM, thank you for your contirbution. Looking forward your next pull request! BTW, before this pr be merged CI should be passed. Let's waiting CI. cc @hailin0 @Hisoka-X @EricJoy2048 @CalvinKirs↳↳
   > > > > 
   > > > > 
   > > > > I have one question, like this #3959↳
   > > > 
   > > > 
   > > > Unified parameters is convenient for frontend display the parameters. Do I understand right? @EricJoy2048↳
   > > 
   > > 
   > > Yes, I like this pr. Thanks for your contirbution.↳
   > 
   > I think you didn't get my point, what we need to consider is compatibility
   
   I think you mean we should support  previous usage only config fields without schema?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org