You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Ash Berlin-Taylor (Jira)" <ji...@apache.org> on 2019/12/18 10:06:00 UTC
[jira] [Commented] (AIRFLOW-5462) Google Authentication redirection
page crashes with KeyError: 'login'
[ https://issues.apache.org/jira/browse/AIRFLOW-5462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16999004#comment-16999004 ]
Ash Berlin-Taylor commented on AIRFLOW-5462:
--------------------------------------------
It seems updating to FAB 2.2.0 alone doesn't fix this.
> Google Authentication redirection page crashes with KeyError: 'login'
> ---------------------------------------------------------------------
>
> Key: AIRFLOW-5462
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5462
> Project: Apache Airflow
> Issue Type: Bug
> Components: authentication
> Affects Versions: 1.10.3, 1.10.4, 1.10.5
> Reporter: Qian Yu
> Priority: Minor
> Fix For: 1.10.7
>
>
> When user is logged out and try to access the URL of a DAG's TreeView, he's redirected to login page. However, after he logs in with google authentication, the page redirects to the oauth-authorized/login page and crashes with a mushroom cloud.
>
> Expected:
> Redirects back to the original URL the user wanted to access
> Actual:
> Crash with mushroom cloud
>
> Configuration:
> {code:python}
> [webserver]
> authenticate = True
> auth_backend = airflow.contrib.auth.backends.google_auth
> [google]
> client_id = google_client_id
> client_secret = google_client_secret
> oauth_callback_route = /oauth2callback
> domain = "example1.com,example2.com"
> {code}
>
> The issue looks similar to the one described here: [https://github.com/apache/incubator-superset/issues/7739]
> {code:python}
> ____/ ( ( ) ) \___
> /( ( ( ) _ )) ) )\
> (( ( )( ) ) ( ) )
> ((/ ( _( ) ( _) ) ( () ) )
> ( ( ( (_) (( ( ) .((_ ) . )_
> ( ( ) ( ( ) ) ) . ) ( )
> ( ( ( ( ) ( _ ( _) ). ) . ) ) ( )
> ( ( ( ) ( ) ( )) ) _)( ) ) )
> ( ( ( \ ) ( (_ ( ) ( ) ) ) ) )) ( )
> ( ( ( ( (_ ( ) ( _ ) ) ( ) ) )
> ( ( ( ( ( ) (_ ) ) ) _) ) _( ( )
> (( ( )( ( _ ) _) _(_ ( (_ )
> (_((__(_(__(( ( ( | ) ) ) )_))__))_)___)
> ((__) \\||lll|l||/// \_))
> ( /(/ ( ) ) )\ )
> ( ( ( ( | | ) ) )\ )
> ( /(| / ( )) ) ) )) )
> ( ( ((((_(|)_))))) )
> ( ||\(|(|)|/|| )
> ( |(||(||)|||| )
> ( //|/l|||)|\\ \ )
> (/ / // /|//||||\\ \ \ \ _)
> -------------------------------------------------------------------------------
> Node: ...
> -------------------------------------------------------------------------------
> Traceback (most recent call last):
> File "/lib/python3.6/site-packages/flask/app.py", line 2446, in wsgi_app
> response = self.full_dispatch_request()
> File "/lib/python3.6/site-packages/flask/app.py", line 1951, in full_dispatch_request
> rv = self.handle_user_exception(e)
> File "/lib/python3.6/site-packages/flask/app.py", line 1820, in handle_user_exception
> reraise(exc_type, exc_value, tb)
> File "/lib/python3.6/site-packages/flask/_compat.py", line 39, in reraise
> raise value
> File "/lib/python3.6/site-packages/flask/app.py", line 1949, in full_dispatch_request
> rv = self.dispatch_request()
> File "/lib/python3.6/site-packages/flask/app.py", line 1935, in dispatch_request
> return self.view_functions[rule.endpoint](**req.view_args)
> File "/lib/python3.6/site-packages/flask_appbuilder/security/views.py", line 633, in oauth_authorized
> resp = self.appbuilder.sm.oauth_remotes[provider].authorized_response()
> KeyError: 'login'
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)