You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/01 06:37:41 UTC
[GitHub] [pulsar] tisonkun opened a new pull request, #16320: [improve][dependency] Remove jul-to-slf4j
tisonkun opened a new pull request, #16320:
URL: https://github.com/apache/pulsar/pull/16320
### Motivation
see also https://lists.apache.org/thread/65skwo492w2nfjwhb3d9y51roq13h8bs
PulsarAdminImpl has a static block requires classpath contains exact either of:
* slf4j-jdk14
* jul-to-slf4j
It causes an issue that if user depends on neither slf4j-jdk14 nor jul-to-slf4j, PulsarAdminImpl will panic with NoClassDefFoundError. And thus, user should add one of them (basically jul-to-slf4j) even if they don't depend on it effectively.
### Modifications
Remove jul-to-slf4j from all modules under Pulsar.
The Pulsar project uses slf4j as the logging facade consistently. If a user want to add a dependency using a different logging framework, they should take care of the packaging strategy themselves.
pulsar-sql will add a dependency to slf4j-jdk14 which redirect slf4j to jul. Since this is a unidirectional redirection, it won't cause runtime error, but pulsar-sql will logging with jul framework, which is the same as with previous workaround.
cc @merlimat as the original author of this stuff.
cc @syhily who points me out this issue.
cc @codelipenghui @eolivelli
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change is already covered by existing tests.
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes)
The motivation and affected scope are described above.
### Documentation
- [x] `doc-not-needed`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #16320: [improve][dependency] Remove jul-to-slf4j
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16320:
URL: https://github.com/apache/pulsar/pull/16320#issuecomment-1179062469
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #16320: [improve][dependency] Remove jul-to-slf4j
Posted by GitBox <gi...@apache.org>.
codelipenghui merged PR #16320:
URL: https://github.com/apache/pulsar/pull/16320
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #16320: [improve][dependency] Remove jul-to-slf4j
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16320:
URL: https://github.com/apache/pulsar/pull/16320#issuecomment-1179647894
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #16320: [improve][dependency] Remove jul-to-slf4j
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16320:
URL: https://github.com/apache/pulsar/pull/16320#issuecomment-1178558899
> Pulsar Bot Command match exactly without whitespace, perhaps we should trim before match comments..
FYI https://github.com/apache/pulsar-test-infra/pull/54
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #16320: [improve][dependency] Remove jul-to-slf4j
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16320:
URL: https://github.com/apache/pulsar/pull/16320#issuecomment-1178889158
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #16320: [improve][dependency] Remove jul-to-slf4j
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16320:
URL: https://github.com/apache/pulsar/pull/16320#issuecomment-1178954514
It seems Broker Group 1 suite often timeout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #16320: [improve][dependency] Remove jul-to-slf4j
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16320:
URL: https://github.com/apache/pulsar/pull/16320#issuecomment-1179648177
"CI - Unit - Brokers - Broker Group 1" failed over days and the failures seem quick weird; for example, `package-info.java` not found but it's exactly there.
@codelipenghui @eolivelli it seems this patch block by those flaky tests. Could you help to confirm and if it's the case, advice what to make progress?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #16320: [improve][dependency] Remove jul-to-slf4j
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16320:
URL: https://github.com/apache/pulsar/pull/16320#issuecomment-1175899174
@codelipenghui thanks for your review!
@eolivelli @merlimat could you give a look at this patch so that we can have an opportunity to include it in 2.11.0 as previously proposed in the mailing list?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on a diff in pull request #16320: [improve][dependency] Remove jul-to-slf4j
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #16320:
URL: https://github.com/apache/pulsar/pull/16320#discussion_r911659101
##########
distribution/server/src/assemble/LICENSE.bin.txt:
##########
@@ -558,7 +558,6 @@ BSD 2-Clause License
MIT License
* Java SemVer -- com.github.zafarkhaja-java-semver-0.9.0.jar -- licenses/LICENSE-SemVer.txt
* SLF4J -- licenses/LICENSE-SLF4J.txt
- - org.slf4j-jul-to-slf4j-1.7.32.jar
- org.slf4j-slf4j-api-1.7.32.jar
- org.slf4j-jcl-over-slf4j-1.7.32.jar
Review Comment:
We need to redirect jcl-over-slf4j due to https://github.com/apache/pulsar/pull/1740 that it's an internal dependency to commons-logging and we should handle within Pulsar itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #16320: [improve][dependency] Remove jul-to-slf4j
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16320:
URL: https://github.com/apache/pulsar/pull/16320#issuecomment-1179133548
Merge master tomorrow to retry running tests. Stop continue rerunning failure tests >_<
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #16320: [improve][dependency] Remove jul-to-slf4j
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16320:
URL: https://github.com/apache/pulsar/pull/16320#issuecomment-1178767628
CPP Tests ever passed at https://github.com/apache/pulsar/runs/7192710852?check_suite_focus=true, all later commits are merge commit.
Broker Tests Group 1 ever passed at https://github.com/apache/pulsar/runs/7153335951?check_suite_focus=true, all later commits are merge commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #16320: [improve][dependency] Remove jul-to-slf4j
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16320:
URL: https://github.com/apache/pulsar/pull/16320#issuecomment-1178953963
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #16320: [improve][dependency] Remove jul-to-slf4j
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16320:
URL: https://github.com/apache/pulsar/pull/16320#issuecomment-1178550756
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #16320: [improve][dependency] Remove jul-to-slf4j
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16320:
URL: https://github.com/apache/pulsar/pull/16320#issuecomment-1182759259
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #16320: [improve][dependency] Remove jul-to-slf4j
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16320:
URL: https://github.com/apache/pulsar/pull/16320#issuecomment-1182725934
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #16320: [improve][dependency] Remove jul-to-slf4j
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16320:
URL: https://github.com/apache/pulsar/pull/16320#issuecomment-1178514980
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #16320: [improve][dependency] Remove jul-to-slf4j
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16320:
URL: https://github.com/apache/pulsar/pull/16320#issuecomment-1179654740
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #16320: [improve][dependency] Remove jul-to-slf4j
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16320:
URL: https://github.com/apache/pulsar/pull/16320#issuecomment-1179499298
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #16320: [improve][dependency] Remove jul-to-slf4j
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16320:
URL: https://github.com/apache/pulsar/pull/16320#issuecomment-1178595742
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #16320: [improve][dependency] Remove jul-to-slf4j
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16320:
URL: https://github.com/apache/pulsar/pull/16320#issuecomment-1179560340
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #16320: [improve][dependency] Remove jul-to-slf4j
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16320:
URL: https://github.com/apache/pulsar/pull/16320#issuecomment-1179493168
OWASP failed on false positive cases, see also https://github.com/eclipse/jetty.project/issues/8161#issuecomment-1178788271. I think it should be resolve on upstream soon later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #16320: [improve][dependency] Remove jul-to-slf4j
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16320:
URL: https://github.com/apache/pulsar/pull/16320#issuecomment-1179662856
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #16320: [improve][dependency] Remove jul-to-slf4j
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16320:
URL: https://github.com/apache/pulsar/pull/16320#issuecomment-1178551014
Pulsar Bot Command match exactly without whitespace, perhaps we should trim before match comments..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #16320: [improve][dependency] Remove jul-to-slf4j
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16320:
URL: https://github.com/apache/pulsar/pull/16320#issuecomment-1178550032
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #16320: [improve][dependency] Remove jul-to-slf4j
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16320:
URL: https://github.com/apache/pulsar/pull/16320#issuecomment-1178814776
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #16320: [improve][dependency] Remove jul-to-slf4j
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16320:
URL: https://github.com/apache/pulsar/pull/16320#issuecomment-1179549300
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] syhily commented on pull request #16320: [improve][dependency] Remove jul-to-slf4j
Posted by GitBox <gi...@apache.org>.
syhily commented on PR #16320:
URL: https://github.com/apache/pulsar/pull/16320#issuecomment-1179123312
Cool. I have been waiting for this for a loooooong time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #16320: [improve][dependency] Remove jul-to-slf4j
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16320:
URL: https://github.com/apache/pulsar/pull/16320#issuecomment-1182759523
@codelipenghui @eolivelli all required CI tasks passed. Could you please help on moving forward this patch?
cc @merlimat
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org