You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "starocean999 (via GitHub)" <gi...@apache.org> on 2023/12/27 10:57:48 UTC

[PR] [feature](fe)support last column or index definition end with comma in create table statement [doris]

starocean999 opened a new pull request, #29167:
URL: https://github.com/apache/doris/pull/29167

   
   ## Proposed changes
   
   Issue Number: close #xxx
   
   <!--Describe your changes.-->
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feature](fe)support last column or index definition end with comma in create table statement [doris]

Posted by "starocean999 (via GitHub)" <gi...@apache.org>.
starocean999 merged PR #29167:
URL: https://github.com/apache/doris/pull/29167


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feature](fe)support last column or index definition end with comma in create table statement [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29167:
URL: https://github.com/apache/doris/pull/29167#issuecomment-1870275770

   
   TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   ```
   Tpch sf100 test result on commit d95d8b4f40a70cf5734e29287994841cde22caee, data reload: false
   
   run tpch-sf100 query with default conf and session variables
   q1	5030	4622	4649	4622
   q2	369	165	158	158
   q3	1479	1342	1265	1265
   q4	1150	973	891	891
   q5	3180	3170	3167	3167
   q6	251	129	127	127
   q7	1023	488	525	488
   q8	2251	2270	2249	2249
   q9	6715	6703	6707	6703
   q10	3222	3290	3260	3260
   q11	330	201	196	196
   q12	350	204	205	204
   q13	4158	3458	3433	3433
   q14	247	214	213	213
   q15	579	528	528	528
   q16	444	392	377	377
   q17	1038	833	646	646
   q18	7081	6756	6731	6731
   q19	1630	1647	1629	1629
   q20	576	332	298	298
   q21	3236	2691	2704	2691
   q22	374	305	307	305
   Total cold run time: 44713 ms
   Total hot run time: 40181 ms
   
   run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
   q1	4595	4578	4555	4555
   q2	272	173	168	168
   q3	3376	3371	3367	3367
   q4	2223	2212	2204	2204
   q5	5721	5731	5719	5719
   q6	237	120	118	118
   q7	2400	1847	1879	1847
   q8	3620	3620	3612	3612
   q9	8965	8994	9003	8994
   q10	3798	3881	3891	3881
   q11	495	372	346	346
   q12	767	601	600	600
   q13	3929	3187	3213	3187
   q14	284	256	242	242
   q15	571	523	530	523
   q16	495	453	451	451
   q17	1955	1964	1945	1945
   q18	8702	8100	8257	8100
   q19	1771	1754	1763	1754
   q20	2238	1937	1920	1920
   q21	6156	5838	5771	5771
   q22	551	467	474	467
   Total cold run time: 63121 ms
   Total hot run time: 59771 ms
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feature](fe)support last column or index definition end with comma in create table statement [doris]

Posted by "starocean999 (via GitHub)" <gi...@apache.org>.
starocean999 commented on PR #29167:
URL: https://github.com/apache/doris/pull/29167#issuecomment-1870192319

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feature](fe)support last column or index definition end with comma in create table statement [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29167:
URL: https://github.com/apache/doris/pull/29167#issuecomment-1871798393

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feature](fe)support last column or index definition end with comma in create table statement [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #29167:
URL: https://github.com/apache/doris/pull/29167#issuecomment-1870225649

   (From new machine)TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 46.99 seconds
    stream load tsv:          568 seconds loaded 74807831229 Bytes, about 125 MB/s
    stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
    stream load orc:          66 seconds loaded 1101869774 Bytes, about 15 MB/s
    stream load parquet:          32 seconds loaded 861443392 Bytes, about 25 MB/s
    insert into select:          28.6 seconds inserted 10000000 Rows, about 349K ops/s
    storage size: 17183541364 Bytes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [feature](fe)support last column or index definition end with comma in create table statement [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #29167:
URL: https://github.com/apache/doris/pull/29167#issuecomment-1871798406

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org