You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sling.apache.org by ra...@apache.org on 2016/08/24 16:39:52 UTC
svn commit: r1757549 -
/sling/trunk/bundles/scripting/sightly/engine/src/main/java/org/apache/sling/scripting/sightly/impl/engine/SightlyScriptEngine.java
Author: radu
Date: Wed Aug 24 16:39:52 2016
New Revision: 1757549
URL: http://svn.apache.org/viewvc?rev=1757549&view=rev
Log:
SLING-6009 - Log compilation warnings
Modified:
sling/trunk/bundles/scripting/sightly/engine/src/main/java/org/apache/sling/scripting/sightly/impl/engine/SightlyScriptEngine.java
Modified: sling/trunk/bundles/scripting/sightly/engine/src/main/java/org/apache/sling/scripting/sightly/impl/engine/SightlyScriptEngine.java
URL: http://svn.apache.org/viewvc/sling/trunk/bundles/scripting/sightly/engine/src/main/java/org/apache/sling/scripting/sightly/impl/engine/SightlyScriptEngine.java?rev=1757549&r1=1757548&r2=1757549&view=diff
==============================================================================
--- sling/trunk/bundles/scripting/sightly/engine/src/main/java/org/apache/sling/scripting/sightly/impl/engine/SightlyScriptEngine.java (original)
+++ sling/trunk/bundles/scripting/sightly/engine/src/main/java/org/apache/sling/scripting/sightly/impl/engine/SightlyScriptEngine.java Wed Aug 24 16:39:52 2016
@@ -44,12 +44,16 @@ import org.apache.sling.scripting.sightl
import org.apache.sling.scripting.sightly.java.compiler.GlobalShadowCheckBackendCompiler;
import org.apache.sling.scripting.sightly.java.compiler.JavaClassBackendCompiler;
import org.apache.sling.scripting.sightly.java.compiler.RenderUnit;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
/**
* The Sightly Script engine
*/
public class SightlyScriptEngine extends AbstractSlingScriptEngine implements Compilable {
+ private static final Logger LOGGER = LoggerFactory.getLogger(SightlyScriptEngine.class);
+
public static final String NO_SCRIPT = "NO_SCRIPT";
private SightlyCompiler sightlyCompiler;
@@ -130,6 +134,12 @@ public class SightlyScriptEngine extends
}
CompilationResult result = shadowCheckBackendCompiler == null ? sightlyCompiler.compile(compilationUnit,
javaClassBackendCompiler) : sightlyCompiler.compile(compilationUnit, shadowCheckBackendCompiler);
+ if (result.getWarnings().size() > 0) {
+ for (CompilerMessage warning : result.getWarnings()) {
+ LOGGER.warn("Script {} {}:{}: {}", new Object[] {warning.getScriptName(), warning.getLine(), warning.getColumn(),
+ warning.getMessage()});
+ }
+ }
if (result.getErrors().size() > 0) {
CompilerMessage error = result.getErrors().get(0);
throw new ScriptException(error.getMessage(), error.getScriptName(), error.getLine(), error.getColumn());