[GitHub] [hudi] nsivabalan commented on a change in pull request #3247: [WIP] Adding soft virtual key support to bulk insert row writer path

[GitBox <gi...@apache.org>]

nsivabalan commented on a change in pull request #3247:
URL: https://github.com/apache/hudi/pull/3247#discussion_r666681609



##########
File path: hudi-spark-datasource/hudi-spark/src/main/java/org/apache/hudi/HoodieDatasetBulkInsertHelper.java
##########
@@ -110,6 +151,55 @@
     Dataset<Row> colOrderedDataset = dedupedDf.select(
         JavaConverters.collectionAsScalaIterableConverter(orderedFields).asScala().toSeq());
 
-    return bulkInsertPartitionerRows.repartitionRecords(colOrderedDataset, config.getBulkInsertShuffleParallelism());
+    return Pair.of(populateMetaCols ? bulkInsertPartitionerRows.repartitionRecords(colOrderedDataset, config.getBulkInsertShuffleParallelism()) :
+        new NonSortPartitionerWithRows().repartitionRecords(colOrderedDataset, config.getBulkInsertShuffleParallelism()), nonPartitionedDataset);
   }
+
+  /**
+   * Add empty meta columns and reorder such that meta columns are at the beginning.
+   *
+   * @param rows
+   * @return
+   */
+  public static Dataset<Row> prepareHoodieDatasetForBulkInsertAppendOnly(Dataset<Row> rows, HoodieWriteConfig config, boolean isGlobalIndex) {

Review comment:
       this method is not used. both flows use the previous method. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org