You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Sriharsha Chintalapani <ha...@hortonworks.com> on 2014/09/27 00:41:37 UTC
Review Request 26107: Patch for KAFKA-1577
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26107/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1577
https://issues.apache.org/jira/browse/KAFKA-1577
Repository: kafka
Description
-------
KAFKA-1577. Exception in ConnectionQuotas while shutting down. added selector operation to refresh selector.keys.
Diffs
-----
core/src/main/scala/kafka/network/SocketServer.scala 3a6f8d121e822e7b6ec32c9147829e91f40e9038
Diff: https://reviews.apache.org/r/26107/diff/
Testing
-------
Thanks,
Sriharsha Chintalapani
Re: Review Request 26107: Patch for KAFKA-1577
Posted by Joel Koshy <jj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26107/#review54764
-----------------------------------------------------------
Ship it!
Ship It!
- Joel Koshy
On Sept. 27, 2014, 2:13 a.m., Sriharsha Chintalapani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26107/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2014, 2:13 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1577
> https://issues.apache.org/jira/browse/KAFKA-1577
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1577. Exception in ConnectionQuotas while shutting down. Removed swalloError for closeAll.
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/network/SocketServer.scala 3a6f8d121e822e7b6ec32c9147829e91f40e9038
>
> Diff: https://reviews.apache.org/r/26107/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sriharsha Chintalapani
>
>
Re: Review Request 26107: Patch for KAFKA-1577
Posted by Sriharsha Chintalapani <ha...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26107/
-----------------------------------------------------------
(Updated Sept. 27, 2014, 2:13 a.m.)
Review request for kafka.
Bugs: KAFKA-1577
https://issues.apache.org/jira/browse/KAFKA-1577
Repository: kafka
Description (updated)
-------
KAFKA-1577. Exception in ConnectionQuotas while shutting down. Removed swalloError for closeAll.
Diffs (updated)
-----
core/src/main/scala/kafka/network/SocketServer.scala 3a6f8d121e822e7b6ec32c9147829e91f40e9038
Diff: https://reviews.apache.org/r/26107/diff/
Testing
-------
Thanks,
Sriharsha Chintalapani
Re: Review Request 26107: Patch for KAFKA-1577
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26107/#review54755
-----------------------------------------------------------
Ship it!
Ship It!
- Neha Narkhede
On Sept. 26, 2014, 10:41 p.m., Sriharsha Chintalapani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26107/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2014, 10:41 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1577
> https://issues.apache.org/jira/browse/KAFKA-1577
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1577. Exception in ConnectionQuotas while shutting down. added selector operation to refresh selector.keys.
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/network/SocketServer.scala 3a6f8d121e822e7b6ec32c9147829e91f40e9038
>
> Diff: https://reviews.apache.org/r/26107/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sriharsha Chintalapani
>
>
Re: Review Request 26107: Patch for KAFKA-1577
Posted by Joel Koshy <jj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26107/#review54760
-----------------------------------------------------------
Looks good - we can now actually get rid of the swallowError when calling closeAll.
- Joel Koshy
On Sept. 26, 2014, 10:41 p.m., Sriharsha Chintalapani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26107/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2014, 10:41 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1577
> https://issues.apache.org/jira/browse/KAFKA-1577
>
>
> Repository: kafka
>
>
> Description
> -------
>
> KAFKA-1577. Exception in ConnectionQuotas while shutting down. added selector operation to refresh selector.keys.
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/network/SocketServer.scala 3a6f8d121e822e7b6ec32c9147829e91f40e9038
>
> Diff: https://reviews.apache.org/r/26107/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sriharsha Chintalapani
>
>