You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2017/07/05 03:45:55 UTC
Review Request 60645: Fix Unit Test Failures Caused by AMBARI-21391
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60645/
-----------------------------------------------------------
Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, and Sid Wagle.
Bugs: AMBARI-21402
https://issues.apache.org/jira/browse/AMBARI-21402
Repository: ambari
Description
-------
Fix the following unit test failures caused by AMBARI-21391:
{code}
Failed tests:
ConfigUpgradeValidityTest.testValidateConfigUpgradePacks:225 File /Users/jhurley/src/apache/ambari/ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml appears to be a config upgrade pack, but does not define 'upgrade-config.xsd' as its schema
Tests in error:
TestActionDBAccessorImpl.testPersistActions:295 » Runtime org.apache.ambari.se...
UpgradeResourceProviderHDP22Test.testCreateIntraStackUpgrade:305 » Runtime org...
UpgradeActionTest.testFinalizeDowngradeWhenDidNotFinalizePreviousUpgrade:531->makeTwoUpgradesWhereLastDidNotComplete:248 » Ambari
ServicePropertiesTest.validatePropertySchemaOfServiceXMLs:50 » Ambari File /Us...
{code}
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 8a54679379
ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml 540c017905
ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml 540c017905
ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java 88fc22d570
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java d13d5ca085
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java a3031670f9
Diff: https://reviews.apache.org/r/60645/diff/1/
Testing
-------
mvn clean test
Thanks,
Jonathan Hurley
Re: Review Request 60645: Fix Unit Test Failures Caused by
AMBARI-21391
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60645/#review179594
-----------------------------------------------------------
Ship it!
Ship It!
- Sid Wagle
On July 5, 2017, 3:45 a.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60645/
> -----------------------------------------------------------
>
> (Updated July 5, 2017, 3:45 a.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, and Sid Wagle.
>
>
> Bugs: AMBARI-21402
> https://issues.apache.org/jira/browse/AMBARI-21402
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Fix the following unit test failures caused by AMBARI-21391:
>
> {code}
> Failed tests:
> ConfigUpgradeValidityTest.testValidateConfigUpgradePacks:225 File /Users/jhurley/src/apache/ambari/ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml appears to be a config upgrade pack, but does not define 'upgrade-config.xsd' as its schema
> Tests in error:
> TestActionDBAccessorImpl.testPersistActions:295 » Runtime org.apache.ambari.se...
> UpgradeResourceProviderHDP22Test.testCreateIntraStackUpgrade:305 » Runtime org...
> UpgradeActionTest.testFinalizeDowngradeWhenDidNotFinalizePreviousUpgrade:531->makeTwoUpgradesWhereLastDidNotComplete:248 » Ambari
> ServicePropertiesTest.validatePropertySchemaOfServiceXMLs:50 » Ambari File /Us...
> {code}
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 8a54679379
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml 540c017905
> ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml 540c017905
> ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java 88fc22d570
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java d13d5ca085
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java a3031670f9
>
>
> Diff: https://reviews.apache.org/r/60645/diff/1/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 60645: Fix Unit Test Failures Caused by
AMBARI-21391
Posted by Attila Doroszlai <ad...@hortonworks.com>.
> On July 5, 2017, 8:26 a.m., Attila Doroszlai wrote:
> > Ship It!
Note that `ServicePropertiesTest` is still failing, although it's not caused by AMBARI-21391.
- Attila
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60645/#review179599
-----------------------------------------------------------
On July 5, 2017, 5:45 a.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60645/
> -----------------------------------------------------------
>
> (Updated July 5, 2017, 5:45 a.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, and Sid Wagle.
>
>
> Bugs: AMBARI-21402
> https://issues.apache.org/jira/browse/AMBARI-21402
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Fix the following unit test failures caused by AMBARI-21391:
>
> {code}
> Failed tests:
> ConfigUpgradeValidityTest.testValidateConfigUpgradePacks:225 File /Users/jhurley/src/apache/ambari/ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml appears to be a config upgrade pack, but does not define 'upgrade-config.xsd' as its schema
> Tests in error:
> TestActionDBAccessorImpl.testPersistActions:295 » Runtime org.apache.ambari.se...
> UpgradeResourceProviderHDP22Test.testCreateIntraStackUpgrade:305 » Runtime org...
> UpgradeActionTest.testFinalizeDowngradeWhenDidNotFinalizePreviousUpgrade:531->makeTwoUpgradesWhereLastDidNotComplete:248 » Ambari
> ServicePropertiesTest.validatePropertySchemaOfServiceXMLs:50 » Ambari File /Us...
> {code}
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 8a54679379
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml 540c017905
> ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml 540c017905
> ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java 88fc22d570
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java d13d5ca085
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java a3031670f9
>
>
> Diff: https://reviews.apache.org/r/60645/diff/1/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 60645: Fix Unit Test Failures Caused by
AMBARI-21391
Posted by Jonathan Hurley <jh...@hortonworks.com>.
> On July 5, 2017, 2:26 a.m., Attila Doroszlai wrote:
> > Ship It!
>
> Attila Doroszlai wrote:
> Note that `ServicePropertiesTest` is still failing, although it's not caused by AMBARI-21391.
Yes, there's an open Jira for that item. The BigInsight stack has a LOT of properties which need to be updated to match the schema correctly.
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60645/#review179599
-----------------------------------------------------------
On July 4, 2017, 11:45 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60645/
> -----------------------------------------------------------
>
> (Updated July 4, 2017, 11:45 p.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, and Sid Wagle.
>
>
> Bugs: AMBARI-21402
> https://issues.apache.org/jira/browse/AMBARI-21402
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Fix the following unit test failures caused by AMBARI-21391:
>
> {code}
> Failed tests:
> ConfigUpgradeValidityTest.testValidateConfigUpgradePacks:225 File /Users/jhurley/src/apache/ambari/ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml appears to be a config upgrade pack, but does not define 'upgrade-config.xsd' as its schema
> Tests in error:
> TestActionDBAccessorImpl.testPersistActions:295 » Runtime org.apache.ambari.se...
> UpgradeResourceProviderHDP22Test.testCreateIntraStackUpgrade:305 » Runtime org...
> UpgradeActionTest.testFinalizeDowngradeWhenDidNotFinalizePreviousUpgrade:531->makeTwoUpgradesWhereLastDidNotComplete:248 » Ambari
> ServicePropertiesTest.validatePropertySchemaOfServiceXMLs:50 » Ambari File /Us...
> {code}
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 8a54679379
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml 540c017905
> ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml 540c017905
> ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java 88fc22d570
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java d13d5ca085
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java a3031670f9
>
>
> Diff: https://reviews.apache.org/r/60645/diff/1/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 60645: Fix Unit Test Failures Caused by
AMBARI-21391
Posted by Attila Doroszlai <ad...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60645/#review179599
-----------------------------------------------------------
Ship it!
Ship It!
- Attila Doroszlai
On July 5, 2017, 5:45 a.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60645/
> -----------------------------------------------------------
>
> (Updated July 5, 2017, 5:45 a.m.)
>
>
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, and Sid Wagle.
>
>
> Bugs: AMBARI-21402
> https://issues.apache.org/jira/browse/AMBARI-21402
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Fix the following unit test failures caused by AMBARI-21391:
>
> {code}
> Failed tests:
> ConfigUpgradeValidityTest.testValidateConfigUpgradePacks:225 File /Users/jhurley/src/apache/ambari/ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml appears to be a config upgrade pack, but does not define 'upgrade-config.xsd' as its schema
> Tests in error:
> TestActionDBAccessorImpl.testPersistActions:295 » Runtime org.apache.ambari.se...
> UpgradeResourceProviderHDP22Test.testCreateIntraStackUpgrade:305 » Runtime org...
> UpgradeActionTest.testFinalizeDowngradeWhenDidNotFinalizePreviousUpgrade:531->makeTwoUpgradesWhereLastDidNotComplete:248 » Ambari
> ServicePropertiesTest.validatePropertySchemaOfServiceXMLs:50 » Ambari File /Us...
> {code}
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java 8a54679379
> ambari-server/src/main/resources/stacks/BigInsights/4.2.5/upgrades/config-upgrade.xml 540c017905
> ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/config-upgrade.xml 540c017905
> ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java 88fc22d570
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java d13d5ca085
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java a3031670f9
>
>
> Diff: https://reviews.apache.org/r/60645/diff/1/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Jonathan Hurley
>
>