[GitHub] [spark] pan3793 commented on a diff in pull request #36418: [SPARK-39079][SQL] Catalog name should not contain dot

[GitBox <gi...@apache.org>]

pan3793 commented on code in PR #36418:
URL: https://github.com/apache/spark/pull/36418#discussion_r869336797


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/Catalogs.scala:
##########
@@ -45,7 +45,11 @@ private[sql] object Catalogs {
   @throws[SparkException]
   def load(name: String, conf: SQLConf): CatalogPlugin = {
     val pluginClassName = try {
-      conf.getConfString("spark.sql.catalog." + name)
+      val _pluginClassName = conf.getConfString("spark.sql.catalog." + name)
+      if (name.contains(".")) {

Review Comment:
   Good idea. Updated code, test case, and PR description.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org