You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/03/14 13:33:39 UTC
[GitHub] [rocketmq-client-cpp] codecov-io commented on issue #274: Fix the
heap-use-after-free risk caused by direct deconstruction when it is not
used after initialization.
codecov-io commented on issue #274: Fix the heap-use-after-free risk caused by direct deconstruction when it is not used after initialization.
URL: https://github.com/apache/rocketmq-client-cpp/pull/274#issuecomment-599061528
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/274?src=pr&el=h1) Report
> Merging [#274](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/274?src=pr&el=desc) into [master](https://codecov.io/gh/apache/rocketmq-client-cpp/commit/753ec41b741cf758b4a6d87dc8976aea2b2ec225&el=desc) will **increase** coverage by `0.26%`.
> The diff coverage is `50.00%`.
[](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/274?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #274 +/- ##
==========================================
+ Coverage 58.28% 58.54% +0.26%
==========================================
Files 182 182
Lines 11805 11810 +5
==========================================
+ Hits 6880 6914 +34
+ Misses 4925 4896 -29
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/274?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/MQClientFactory.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/274/diff?src=pr&el=tree#diff-c3JjL01RQ2xpZW50RmFjdG9yeS5jcHA=) | `22.90% <44.44%> (+2.12%)` | :arrow_up: |
| [test/src/MQClientManagerTest.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/274/diff?src=pr&el=tree#diff-dGVzdC9zcmMvTVFDbGllbnRNYW5hZ2VyVGVzdC5jcHA=) | `100.00% <100.00%> (ø)` | |
| [src/MQClientAPIImpl.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/274/diff?src=pr&el=tree#diff-c3JjL01RQ2xpZW50QVBJSW1wbC5jcHA=) | `24.89% <0.00%> (+0.41%)` | :arrow_up: |
| [src/transport/TcpRemotingClient.cpp](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/274/diff?src=pr&el=tree#diff-c3JjL3RyYW5zcG9ydC9UY3BSZW1vdGluZ0NsaWVudC5jcHA=) | `13.76% <0.00%> (+4.49%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/274?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/274?src=pr&el=footer). Last update [753ec41...b79abb4](https://codecov.io/gh/apache/rocketmq-client-cpp/pull/274?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services