You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "XiaoyangCai360 (via GitHub)" <gi...@apache.org> on 2025/11/20 18:46:50 UTC
[PR] test: Deflake DataCompareUtilsTest due to Map key iteration order [incubator-seata]
XiaoyangCai360 opened a new pull request, #7803:
URL: https://github.com/apache/incubator-seata/pull/7803
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<!-- Please make sure you have read and understood the contributing guidelines -->
- [x] I have read the [CONTRIBUTING.md](https://github.com/apache/incubator-seata/blob/2.x/CONTRIBUTING.md) guidelines.
- [x] I have registered the PR [changes](https://github.com/apache/incubator-seata/tree/2.x/changes).
### Ⅰ. Describe what this PR did
This PR fixes flakiness in the unit tests of `DataCompareUtilsTest.java` within the `rm-datasource` module.
The tests `testRowListToMapWithSinglePk` and `testRowListToMapWithMultipPk` were failing intermittently because they asserted the iteration order of keys returned from `DataCompareUtils.rowListToMap()` using `keySet().iterator().next()`. Since the underlying map implementation does not guarantee key order, this assertion was non-deterministic.
The fix replaces the order-dependent check with an order-independent assertion (`containsKey()`), verifying the existence of an expected primary key in the resulting map, thereby stabilizing the tests.
**No production code changes were made; this is a test-only change to improve CI stability.**
### Ⅱ. Does this pull request fix one issue?
<!-- If that, add "fixes #xxx" below in the next line, for example, fixes #97. -->
### Ⅲ. Why don't you add test cases (unit test/integration test)?
This PR is a fix for existing flaky unit tests.
### Ⅳ. Describe how to verify it
To confirm the flakiness is resolved, run the affected test repeatedly using a non-deterministic test runner such as [nondex](https://github.com/TestingResearchIllinois/NonDex). Successful runs across multiple attempts verify the fix:
```bash
mvn -pl rm-datasource \
-am edu.illinois:nondex-maven-plugin:2.1.7:nondex \
-Dtest=org.apache.seata.rm.datasource.DataCompareUtilsTest \
-DnondexRuns=10 \
-DfailIfNoTests=false
```
### Ⅴ. Special notes for reviews
- Test-only change in `rm-datasource` module (`DataCompareUtilsTest.java`).
- No production code touched
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] test: Deflake DataCompareUtilsTest due to Map key iteration order [incubator-seata]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7803:
URL: https://github.com/apache/incubator-seata/pull/7803#issuecomment-3561056469
## [Codecov](https://app.codecov.io/gh/apache/incubator-seata/pull/7803?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 69.98%. Comparing base ([`4959cfb`](https://app.codecov.io/gh/apache/incubator-seata/commit/4959cfb49009d3e4c349fd2c95e590184bd5a9a8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`25a2ad1`](https://app.codecov.io/gh/apache/incubator-seata/commit/25a2ad1c7f68d9e5c485617b013142ac435f85a9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on 2.x.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 2.x #7803 +/- ##
============================================
+ Coverage 69.93% 69.98% +0.04%
Complexity 992 992
============================================
Files 1322 1322
Lines 50175 50175
Branches 5932 5932
============================================
+ Hits 35091 35116 +25
+ Misses 12150 12127 -23
+ Partials 2934 2932 -2
```
[see 11 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-seata/pull/7803/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
[](https://app.codecov.io/gh/apache/incubator-seata/pull/7803?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] test: fix flaky DataCompareUtilsTest caused by nondeterministic Map key iteration order [incubator-seata]
Posted by "YvCeung (via GitHub)" <gi...@apache.org>.
YvCeung commented on PR #7803:
URL: https://github.com/apache/incubator-seata/pull/7803#issuecomment-3567975217
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] test: fix flaky DataCompareUtilsTest caused by nondeterministic Map key iteration order [incubator-seata]
Posted by "YvCeung (via GitHub)" <gi...@apache.org>.
YvCeung merged PR #7803:
URL: https://github.com/apache/incubator-seata/pull/7803
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org