You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/23 08:23:48 UTC
[GitHub] [spark] huaxingao opened a new pull request #34997: [SPARK-37496][SQL][FOLLOWUP] DataFrameWriter.saveAsTable should take write options in CTAS and RTAS
huaxingao opened a new pull request #34997:
URL: https://github.com/apache/spark/pull/34997
### What changes were proposed in this pull request?
`DataFrameWriter.saveAsTable` should pass `extraOptions.toMap` as the write options in CTAS and RTAS
### Why are the changes needed?
bug fixing
please see https://github.com/apache/spark/pull/34754#discussion_r771059560 https://github.com/apache/spark/pull/34667#discussion_r771367364
### Does this PR introduce _any_ user-facing change?
no
### How was this patch tested?
new test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34997: [SPARK-37496][SQL][FOLLOWUP] DataFrameWriter.saveAsTable should take write options in CTAS and RTAS
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34997:
URL: https://github.com/apache/spark/pull/34997#issuecomment-1000169488
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50987/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34997: [SPARK-37496][SQL][FOLLOWUP] DataFrameWriter.saveAsTable should take write options in CTAS and RTAS
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34997:
URL: https://github.com/apache/spark/pull/34997#issuecomment-1000144497
**[Test build #146511 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146511/testReport)** for PR 34997 at commit [`ab9ffd1`](https://github.com/apache/spark/commit/ab9ffd18f80ed0d35dc7011ea527ec6546c12037).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34997: [SPARK-37496][SQL][FOLLOWUP] DataFrameWriter.saveAsTable should take write options in CTAS and RTAS
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34997:
URL: https://github.com/apache/spark/pull/34997#issuecomment-1000325239
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146511/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34997: [SPARK-37496][SQL][FOLLOWUP] DataFrameWriter.saveAsTable should take write options in CTAS and RTAS
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34997:
URL: https://github.com/apache/spark/pull/34997#issuecomment-1000209429
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/50987/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34997: [SPARK-37496][SQL][FOLLOWUP] DataFrameWriter.saveAsTable should take write options in CTAS and RTAS
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34997:
URL: https://github.com/apache/spark/pull/34997#issuecomment-1000325239
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/146511/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34997: [SPARK-37496][SQL][FOLLOWUP] DataFrameWriter.saveAsTable should take write options in CTAS and RTAS
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34997:
URL: https://github.com/apache/spark/pull/34997#issuecomment-1000213367
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50987/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34997: [SPARK-37496][SQL][FOLLOWUP] DataFrameWriter.saveAsTable should take write options in CTAS and RTAS
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34997:
URL: https://github.com/apache/spark/pull/34997#issuecomment-1000213367
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/50987/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34997: [SPARK-37496][SQL][FOLLOWUP] DataFrameWriter.saveAsTable should take write options in CTAS and RTAS
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34997:
URL: https://github.com/apache/spark/pull/34997#issuecomment-1000144497
**[Test build #146511 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146511/testReport)** for PR 34997 at commit [`ab9ffd1`](https://github.com/apache/spark/commit/ab9ffd18f80ed0d35dc7011ea527ec6546c12037).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huaxingao commented on pull request #34997: [SPARK-37496][SQL][FOLLOWUP] DataFrameWriter.saveAsTable should take write options in CTAS and RTAS
Posted by GitBox <gi...@apache.org>.
huaxingao commented on pull request #34997:
URL: https://github.com/apache/spark/pull/34997#issuecomment-1000626533
cc @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34997: [SPARK-37496][SQL][FOLLOWUP] DataFrameWriter.saveAsTable should take write options in CTAS and RTAS
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34997:
URL: https://github.com/apache/spark/pull/34997#issuecomment-1000321147
**[Test build #146511 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/146511/testReport)** for PR 34997 at commit [`ab9ffd1`](https://github.com/apache/spark/commit/ab9ffd18f80ed0d35dc7011ea527ec6546c12037).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #34997: [SPARK-37496][SQL][FOLLOWUP] DataFrameWriter.saveAsTable should take write options in CTAS and RTAS
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #34997:
URL: https://github.com/apache/spark/pull/34997#issuecomment-1001519469
The GA failure is unrelated, merging to master, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #34997: [SPARK-37496][SQL][FOLLOWUP] DataFrameWriter.saveAsTable should take write options in CTAS and RTAS
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #34997:
URL: https://github.com/apache/spark/pull/34997
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org