You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Mona Chitnis <ch...@yahoo-inc.com> on 2011/10/07 20:07:17 UTC
Review Request: OOZIE-553: Ability to view the log for coordinator actions
that ran in a date range
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2274/
-----------------------------------------------------------
Review request for oozie, Mohammad Islam and Angelo K. Huang.
Summary
-------
This is on behalf of Kiran N.'s work on oozie logs
Diffs
-----
trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1179918
trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1179918
trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java 1179918
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionsInDateRangeXCommand.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionsInDateRangeXCommand.java PRE-CREATION
trunk/release-log.txt 1179918
Diff: https://reviews.apache.org/r/2274/diff
Testing
-------
Thanks,
Mona
Re: Review Request: OOZIE-553: Ability to view the log for coordinator
actions that ran in a date range
Posted by Mona Chitnis <ch...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2274/#review2491
-----------------------------------------------------------
trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java
<https://reviews.apache.org/r/2274/#comment5631>
reverting this accidental change
- Mona
On 2011-10-08 02:39:35, Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2274/
> -----------------------------------------------------------
>
> (Updated 2011-10-08 02:39:35)
>
>
> Review request for oozie, Mohammad Islam and Angelo K. Huang.
>
>
> Summary
> -------
>
> This is on behalf of Kiran N.'s work on oozie logs
>
> Date range for log retrieval
> - User can add the command line option -date(Ex.: -date 2011-01-01T01:00Z::2011-05-31T23:59Z) along with the -log option
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1180295
> trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1180295
> trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java 1180295
> trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/util/TestCoordActionsInDateRange.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/2274/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mona
>
>
Re: Review Request: OOZIE-553: Ability to view the log for coordinator
actions that ran in a date range
Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2274/#review2633
-----------------------------------------------------------
Committed. Please close the resources (review request/JIRA).
- Mohammad
On 2011-10-17 19:59:01, Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2274/
> -----------------------------------------------------------
>
> (Updated 2011-10-17 19:59:01)
>
>
> Review request for oozie, Mohammad Islam and Angelo K. Huang.
>
>
> Summary
> -------
>
> This is on behalf of Kiran N.'s work on oozie logs
>
> Date range for log retrieval
> - User can add the command line option -date(Ex.: -date 2011-01-01T01:00Z::2011-05-31T23:59Z) along with the -log option
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1181286
> trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1181286
> trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java 1181286
> trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/util/TestCoordActionsInDateRange.java PRE-CREATION
> trunk/release-log.txt 1181286
>
> Diff: https://reviews.apache.org/r/2274/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mona
>
>
Re: Review Request: OOZIE-553: Ability to view the log for coordinator
actions that ran in a date range
Posted by Santhosh Srinivasan <sm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2274/#review2629
-----------------------------------------------------------
Minor comments. Otherwise its good to go.
trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java
<https://reviews.apache.org/r/2274/#comment5937>
It should be date range instead of date's range.
trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java
<https://reviews.apache.org/r/2274/#comment5938>
It should be date range instead of date's range.
trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java
<https://reviews.apache.org/r/2274/#comment5939>
It should be date range instead of date's range.
trunk/core/src/test/java/org/apache/oozie/util/TestCoordActionsInDateRange.java
<https://reviews.apache.org/r/2274/#comment5935>
Operator precedence will take care of the division prior to the subtraction. For code clarity, its better to do the following:
(nominalTimeMilliseconds - (noOfMilliseconds inOneHour / 2))
trunk/core/src/test/java/org/apache/oozie/util/TestCoordActionsInDateRange.java
<https://reviews.apache.org/r/2274/#comment5936>
Operator precedence will take care of the division prior to the subtraction. For code clarity, its better to do the following:
(nominalTimeMilliseconds + (noOfMilliseconds inOneHour / 2))
- Santhosh
On 2011-10-17 19:59:01, Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2274/
> -----------------------------------------------------------
>
> (Updated 2011-10-17 19:59:01)
>
>
> Review request for oozie, Mohammad Islam and Angelo K. Huang.
>
>
> Summary
> -------
>
> This is on behalf of Kiran N.'s work on oozie logs
>
> Date range for log retrieval
> - User can add the command line option -date(Ex.: -date 2011-01-01T01:00Z::2011-05-31T23:59Z) along with the -log option
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1181286
> trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1181286
> trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java 1181286
> trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/util/TestCoordActionsInDateRange.java PRE-CREATION
> trunk/release-log.txt 1181286
>
> Diff: https://reviews.apache.org/r/2274/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mona
>
>
Re: Review Request: OOZIE-553: Ability to view the log for coordinator
actions that ran in a date range
Posted by Santhosh Srinivasan <sm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2274/#review2630
-----------------------------------------------------------
Ship it!
- Santhosh
On 2011-10-17 19:59:01, Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2274/
> -----------------------------------------------------------
>
> (Updated 2011-10-17 19:59:01)
>
>
> Review request for oozie, Mohammad Islam and Angelo K. Huang.
>
>
> Summary
> -------
>
> This is on behalf of Kiran N.'s work on oozie logs
>
> Date range for log retrieval
> - User can add the command line option -date(Ex.: -date 2011-01-01T01:00Z::2011-05-31T23:59Z) along with the -log option
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1181286
> trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1181286
> trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java 1181286
> trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/util/TestCoordActionsInDateRange.java PRE-CREATION
> trunk/release-log.txt 1181286
>
> Diff: https://reviews.apache.org/r/2274/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mona
>
>
Re: Review Request: OOZIE-553: Ability to view the log for coordinator
actions that ran in a date range
Posted by Mona Chitnis <ch...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2274/
-----------------------------------------------------------
(Updated 2011-10-17 19:59:01.473456)
Review request for oozie, Mohammad Islam and Angelo K. Huang.
Changes
-------
added clarity with code comments explaining
- the added condition block in CoordinatorEngine to filter logs based on a date variable and
- specifying correct date range format parsed by the new utility class CoordActionsInDateRange
Summary
-------
This is on behalf of Kiran N.'s work on oozie logs
Date range for log retrieval
- User can add the command line option -date(Ex.: -date 2011-01-01T01:00Z::2011-05-31T23:59Z) along with the -log option
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1181286
trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1181286
trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java 1181286
trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/util/TestCoordActionsInDateRange.java PRE-CREATION
trunk/release-log.txt 1181286
Diff: https://reviews.apache.org/r/2274/diff
Testing
-------
Thanks,
Mona
Re: Review Request: OOZIE-553: Ability to view the log for coordinator
actions that ran in a date range
Posted by Mona Chitnis <ch...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2274/
-----------------------------------------------------------
(Updated 2011-10-14 23:33:17.304268)
Review request for oozie, Mohammad Islam and Angelo K. Huang.
Changes
-------
feedback incorporated
Summary
-------
This is on behalf of Kiran N.'s work on oozie logs
Date range for log retrieval
- User can add the command line option -date(Ex.: -date 2011-01-01T01:00Z::2011-05-31T23:59Z) along with the -log option
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1181286
trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1181286
trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java 1181286
trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/util/TestCoordActionsInDateRange.java PRE-CREATION
trunk/release-log.txt 1181286
Diff: https://reviews.apache.org/r/2274/diff
Testing
-------
Thanks,
Mona
Re: Review Request: OOZIE-553: Ability to view the log for coordinator
actions that ran in a date range
Posted by "Angelo K. Huang" <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2274/#review2542
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java
<https://reviews.apache.org/r/2274/#comment5710>
Not sure why it needs to be static. It is used only once.
trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java
<https://reviews.apache.org/r/2274/#comment5711>
you can move jpa service declaration here.
- Angelo K.
On 2011-10-10 19:23:54, Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2274/
> -----------------------------------------------------------
>
> (Updated 2011-10-10 19:23:54)
>
>
> Review request for oozie, Mohammad Islam and Angelo K. Huang.
>
>
> Summary
> -------
>
> This is on behalf of Kiran N.'s work on oozie logs
>
> Date range for log retrieval
> - User can add the command line option -date(Ex.: -date 2011-01-01T01:00Z::2011-05-31T23:59Z) along with the -log option
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1181106
> trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1181106
> trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java 1181106
> trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/util/TestCoordActionsInDateRange.java PRE-CREATION
> trunk/release-log.txt 1181106
>
> Diff: https://reviews.apache.org/r/2274/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mona
>
>
Re: Review Request: OOZIE-553: Ability to view the log for coordinator
actions that ran in a date range
Posted by Mona Chitnis <ch...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2274/#review2605
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java
<https://reviews.apache.org/r/2274/#comment5841>
you're right. Adding the clarification in the error message
- Mona
On 2011-10-10 19:23:54, Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2274/
> -----------------------------------------------------------
>
> (Updated 2011-10-10 19:23:54)
>
>
> Review request for oozie, Mohammad Islam and Angelo K. Huang.
>
>
> Summary
> -------
>
> This is on behalf of Kiran N.'s work on oozie logs
>
> Date range for log retrieval
> - User can add the command line option -date(Ex.: -date 2011-01-01T01:00Z::2011-05-31T23:59Z) along with the -log option
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1181106
> trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1181106
> trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java 1181106
> trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/util/TestCoordActionsInDateRange.java PRE-CREATION
> trunk/release-log.txt 1181106
>
> Diff: https://reviews.apache.org/r/2274/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mona
>
>
Re: Review Request: OOZIE-553: Ability to view the log for coordinator
actions that ran in a date range
Posted by Mona Chitnis <ch...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2274/
-----------------------------------------------------------
(Updated 2011-10-10 19:23:54.266600)
Review request for oozie, Mohammad Islam and Angelo K. Huang.
Changes
-------
updated after reviewer feedback
Summary
-------
This is on behalf of Kiran N.'s work on oozie logs
Date range for log retrieval
- User can add the command line option -date(Ex.: -date 2011-01-01T01:00Z::2011-05-31T23:59Z) along with the -log option
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1181106
trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1181106
trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java 1181106
trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/util/TestCoordActionsInDateRange.java PRE-CREATION
trunk/release-log.txt 1181106
Diff: https://reviews.apache.org/r/2274/diff
Testing
-------
Thanks,
Mona
Re: Review Request: OOZIE-553: Ability to view the log for coordinator
actions that ran in a date range
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2274/#review2468
-----------------------------------------------------------
trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java
<https://reviews.apache.org/r/2274/#comment5576>
This change is from previous commit
trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java
<https://reviews.apache.org/r/2274/#comment5577>
Documentation comment for private method
Its better to use implementation comment (/*...*/)
- Virag
On 2011-10-08 02:39:35, Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2274/
> -----------------------------------------------------------
>
> (Updated 2011-10-08 02:39:35)
>
>
> Review request for oozie, Mohammad Islam and Angelo K. Huang.
>
>
> Summary
> -------
>
> This is on behalf of Kiran N.'s work on oozie logs
>
> Date range for log retrieval
> - User can add the command line option -date(Ex.: -date 2011-01-01T01:00Z::2011-05-31T23:59Z) along with the -log option
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1180295
> trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1180295
> trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java 1180295
> trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/util/TestCoordActionsInDateRange.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/2274/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mona
>
>
Re: Review Request: OOZIE-553: Ability to view the log for coordinator
actions that ran in a date range
Posted by Mona Chitnis <ch...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2274/
-----------------------------------------------------------
(Updated 2011-10-08 02:39:35.204622)
Review request for oozie, Mohammad Islam and Angelo K. Huang.
Changes
-------
refactored code from previous diff to incorporate review comments
Summary
-------
This is on behalf of Kiran N.'s work on oozie logs
Date range for log retrieval
- User can add the command line option -date(Ex.: -date 2011-01-01T01:00Z::2011-05-31T23:59Z) along with the -log option
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1180295
trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1180295
trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java 1180295
trunk/core/src/main/java/org/apache/oozie/util/CoordActionsInDateRange.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/util/TestCoordActionsInDateRange.java PRE-CREATION
Diff: https://reviews.apache.org/r/2274/diff
Testing
-------
Thanks,
Mona
Re: Review Request: OOZIE-553: Ability to view the log for coordinator
actions that ran in a date range
Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2274/#review2447
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java
<https://reviews.apache.org/r/2274/#comment5555>
formatting pls. why in three lines?
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionsInDateRangeXCommand.java
<https://reviews.apache.org/r/2274/#comment5556>
remove spaces
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionsInDateRangeXCommand.java
<https://reviews.apache.org/r/2274/#comment5558>
Does not fit into command classes.
It could be a separate utility class or a private methods in the coordinatorEngine.
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionsInDateRangeXCommand.java
<https://reviews.apache.org/r/2274/#comment5557>
spaces pls
- Mohammad
On 2011-10-07 22:15:25, Mona Chitnis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2274/
> -----------------------------------------------------------
>
> (Updated 2011-10-07 22:15:25)
>
>
> Review request for oozie, Mohammad Islam and Angelo K. Huang.
>
>
> Summary
> -------
>
> This is on behalf of Kiran N.'s work on oozie logs
>
> Date range for log retrieval
> - User can add the command line option -date(Ex.: -date 2011-01-01T01:00Z::2011-05-31T23:59Z) along with the -log option
>
>
> Diffs
> -----
>
> trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1179918
> trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1179918
> trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java 1179918
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionsInDateRangeXCommand.java PRE-CREATION
> trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionsInDateRangeXCommand.java PRE-CREATION
> trunk/release-log.txt 1179918
>
> Diff: https://reviews.apache.org/r/2274/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mona
>
>
Re: Review Request: OOZIE-553: Ability to view the log for coordinator
actions that ran in a date range
Posted by Mona Chitnis <ch...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2274/
-----------------------------------------------------------
(Updated 2011-10-07 22:15:25.926631)
Review request for oozie, Mohammad Islam and Angelo K. Huang.
Summary (updated)
-------
This is on behalf of Kiran N.'s work on oozie logs
Date range for log retrieval
- User can add the command line option -date(Ex.: -date 2011-01-01T01:00Z::2011-05-31T23:59Z) along with the -log option
Diffs
-----
trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1179918
trunk/client/src/main/java/org/apache/oozie/client/rest/RestConstants.java 1179918
trunk/core/src/main/java/org/apache/oozie/CoordinatorEngine.java 1179918
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionsInDateRangeXCommand.java PRE-CREATION
trunk/core/src/test/java/org/apache/oozie/command/coord/TestCoordActionsInDateRangeXCommand.java PRE-CREATION
trunk/release-log.txt 1179918
Diff: https://reviews.apache.org/r/2274/diff
Testing
-------
Thanks,
Mona