You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "Hani Suleiman (JIRA)" <ji...@apache.org> on 2008/07/17 15:27:31 UTC
[jira] Created: (CXF-1705) Servlet 2.3 compliance
Servlet 2.3 compliance
----------------------
Key: CXF-1705
URL: https://issues.apache.org/jira/browse/CXF-1705
Project: CXF
Issue Type: Improvement
Components: Transports
Affects Versions: 2.1.1
Reporter: Hani Suleiman
Fix For: 2.1.2
Attachments: cxf-1705.patch
Currently there is one call to the servlet 2.4 API in ServletController. This can be made 2.3 compatible by specifying the encoding in the setContentType(...) call. Attached is a patch to fix this, and enable cxf to run in any servlet 2.3 container.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CXF-1705) Servlet 2.3 compliance
Posted by "Glen Mazza (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614389#action_12614389 ]
Glen Mazza commented on CXF-1705:
---------------------------------
OK, I'll defer to your judgment on this.
> Servlet 2.3 compliance
> ----------------------
>
> Key: CXF-1705
> URL: https://issues.apache.org/jira/browse/CXF-1705
> Project: CXF
> Issue Type: Improvement
> Components: Transports
> Affects Versions: 2.1.1
> Reporter: Hani Suleiman
> Fix For: 2.1.2
>
> Attachments: cxf-1705.patch
>
>
> Currently there is one call to the servlet 2.4 API in ServletController. This can be made 2.3 compatible by specifying the encoding in the setContentType(...) call. Attached is a patch to fix this, and enable cxf to run in any servlet 2.3 container.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CXF-1705) Servlet 2.3 compliance
Posted by "Glen Mazza (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614375#action_12614375 ]
Glen Mazza commented on CXF-1705:
---------------------------------
I'm -0.5 on this. Servlet 2.3 is Tomcat 4.x--that's kind of old, isn't it? I think this change would be of limited benefit because CXF still needs JDK 5.0+. I would say, security-wise, CXF web services should not be running on something as old as Tomcat 4.x--go to Axis 1.x for that. Another concern is that if you advertise that CXF supports Tomcat 4.x+, might people think that CXF is kind of old and hasn't been updated and modernized over the past few years.
> Servlet 2.3 compliance
> ----------------------
>
> Key: CXF-1705
> URL: https://issues.apache.org/jira/browse/CXF-1705
> Project: CXF
> Issue Type: Improvement
> Components: Transports
> Affects Versions: 2.1.1
> Reporter: Hani Suleiman
> Fix For: 2.1.2
>
> Attachments: cxf-1705.patch
>
>
> Currently there is one call to the servlet 2.4 API in ServletController. This can be made 2.3 compatible by specifying the encoding in the setContentType(...) call. Attached is a patch to fix this, and enable cxf to run in any servlet 2.3 container.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CXF-1705) Servlet 2.3 compliance
Posted by "Hani Suleiman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614427#action_12614427 ]
Hani Suleiman commented on CXF-1705:
------------------------------------
Exactly what Daniel said.
There are tons of deployments that are still 2.3 (running with 1.5 JVMs). You don't need to advertise that this works with tomcat 4.x, just don't explicitly say it doesnt. If anyone tries to sue you for it, then you can say it doesnt work with Tomcat 4.x.
The change I'm proposing is a one liner, and it makes everything work (or at the very least, you can serve up WSDLs, handle requests, and so on). Without it, the servlet cannot service any requests at all.
I don't want to get into a debate about it, but to be honest, every single reason you gave against this patch was...dubious at best! If youre still unconvinced I'll gladly post more refuting every one of them ;)
> Servlet 2.3 compliance
> ----------------------
>
> Key: CXF-1705
> URL: https://issues.apache.org/jira/browse/CXF-1705
> Project: CXF
> Issue Type: Improvement
> Components: Transports
> Affects Versions: 2.1.1
> Reporter: Hani Suleiman
> Fix For: 2.1.2
>
> Attachments: cxf-1705.patch
>
>
> Currently there is one call to the servlet 2.4 API in ServletController. This can be made 2.3 compatible by specifying the encoding in the setContentType(...) call. Attached is a patch to fix this, and enable cxf to run in any servlet 2.3 container.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CXF-1705) Servlet 2.3 compliance
Posted by "Daniel Kulp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Kulp resolved CXF-1705.
------------------------------
Resolution: Fixed
Fix Version/s: 2.0.8
Assignee: Daniel Kulp
Patch applied! Thanks!
> Servlet 2.3 compliance
> ----------------------
>
> Key: CXF-1705
> URL: https://issues.apache.org/jira/browse/CXF-1705
> Project: CXF
> Issue Type: Improvement
> Components: Transports
> Affects Versions: 2.1.1
> Reporter: Hani Suleiman
> Assignee: Daniel Kulp
> Fix For: 2.1.2, 2.0.8
>
> Attachments: cxf-1705.patch
>
>
> Currently there is one call to the servlet 2.4 API in ServletController. This can be made 2.3 compatible by specifying the encoding in the setContentType(...) call. Attached is a patch to fix this, and enable cxf to run in any servlet 2.3 container.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CXF-1705) Servlet 2.3 compliance
Posted by "Daniel Kulp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614387#action_12614387 ]
Daniel Kulp commented on CXF-1705:
----------------------------------
Tomcat 4.x isn't the only 2.3 servlet container. Weblogic and Webspere versions only a couple years old (and still used all over the place in production) are 2.3. Thus, it's not a BAD idea if it's just one api call. It reduces some headaches of servlet-api jar version missmatches and all other kinds of muck like that.
> Servlet 2.3 compliance
> ----------------------
>
> Key: CXF-1705
> URL: https://issues.apache.org/jira/browse/CXF-1705
> Project: CXF
> Issue Type: Improvement
> Components: Transports
> Affects Versions: 2.1.1
> Reporter: Hani Suleiman
> Fix For: 2.1.2
>
> Attachments: cxf-1705.patch
>
>
> Currently there is one call to the servlet 2.4 API in ServletController. This can be made 2.3 compatible by specifying the encoding in the setContentType(...) call. Attached is a patch to fix this, and enable cxf to run in any servlet 2.3 container.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CXF-1705) Servlet 2.3 compliance
Posted by "Hani Suleiman (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CXF-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hani Suleiman updated CXF-1705:
-------------------------------
Attachment: cxf-1705.patch
> Servlet 2.3 compliance
> ----------------------
>
> Key: CXF-1705
> URL: https://issues.apache.org/jira/browse/CXF-1705
> Project: CXF
> Issue Type: Improvement
> Components: Transports
> Affects Versions: 2.1.1
> Reporter: Hani Suleiman
> Fix For: 2.1.2
>
> Attachments: cxf-1705.patch
>
>
> Currently there is one call to the servlet 2.4 API in ServletController. This can be made 2.3 compatible by specifying the encoding in the setContentType(...) call. Attached is a patch to fix this, and enable cxf to run in any servlet 2.3 container.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.