[GitHub] [spark] bersprockets commented on pull request #39518: [SPARK-41991][SQL] `CheckOverflowInTableInsert` should accept ExpressionProxy as child

[GitBox <gi...@apache.org>]

bersprockets commented on PR #39518:
URL: https://github.com/apache/spark/pull/39518#issuecomment-1381055130

   @rednaxelafx 
   
   >Should we fix all occurrences of such pattern
   
   I checked this at some point. I could find only two additional cases:
   
   `SortOrder`
   `GeneratorOuter`
   
   I don't think either would show up in a projection, unless I misunderstand them.
   
   This also assumes my regex search is any good:
   
   ```
   find . -name "*.scala" | grep -v '/test' | xargs egrep -n -A5 '.*def withNewChildInternal' | grep '.asInstanceOf'
   ```
   There could be places where `withNewChildInternal` allows any expression but other methods assume a more specific type of expression. That would not be covered by my regex search, of course.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org