You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2026/07/14 09:30:30 UTC

[PR] Clean up redundant MCP workflow helpers [shardingsphere]

terrymanu opened a new pull request, #39108:
URL: https://github.com/apache/shardingsphere/pull/39108

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Clean up redundant MCP workflow helpers [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on PR #39108:
URL: https://github.com/apache/shardingsphere/pull/39108#issuecomment-4967582128

   ### Summary
   
   **Review Result: Mergeable**
   
   **Reason:** No code-level blockers were found. The PR directly removes a test-only production constant and redundant forwarding methods while preserving runtime behavior, exception boundaries, and the externally visible MCP contract. This result covers code correctness only; CI was not reviewed by request.
   
   ### Evidence
   
   - All repository usages of `MCPWorkflowApplySynchronizationHandler.NO_OP` were in `WorkflowExecutionServiceTest`. The PR replaces it with a private, stateless test handler instead of exposing a test fixture through the production SPI.
   - The synchronization call at `mcp/core/.../WorkflowExecutionService.java:257` remains under the original `!applyOutcome.hasSkippedArtifacts()` condition and within the same `try` block. The handling order for `WorkflowSynchronizationException` and other runtime exceptions is unchanged.
   - The changes at `MaskWorkflowToolResponseBuilder.java:37` and `ShardingAlgorithmRecommendationService.java:57` only inline equivalent object access. They do not change inputs, return values, null semantics, or side effects.
   - Existing behavioral tests cover successful synchronization, skipped synchronization, synchronization failure, Mask response construction, and Sharding key-generator recommendations.
   - The removed SPI constant was introduced after the initial MCP contribution. The latest release tag, `5.5.3`, does not contain the MCP module, while the current version is `5.5.4-SNAPSHOT`; therefore, no released API is being removed.
   - The PR contains only five related files. The GitHub `/pulls/39108/files` response exactly matches the local triple-dot file list, with no substantive unrelated changes.
   
   ### Review Details
   
   - **Review Focus:** Code Correctness Review. CI not reviewed by request.
   - **Reviewed Scope:** PR head `c59b59554e37c70a9ec71828ad4328c613b53184`; base and merge-base `5da445bbce8161b91d2d22007a105479490b4ad2`; full review of the `mcp/support` SPI, `mcp/core` workflow execution and tests, the Mask response builder, and the Sharding recommendation service.
   - **Not Reviewed Scope:** GitHub Actions, MCP E2E, and unrelated modules not modified by this PR.
   - **Verification:** `./mvnw -pl mcp/core,mcp/features/sharding,mcp/features/mask -am test ...` exited with code `0`, with 30 tests passing; `./mvnw checkstyle:check -Pcheck -T1C` exited with code `0`.
   - **Release Note / User Docs:** Not required. This PR does not change user-visible behavior, MCP schemas, descriptors, transports, configuration, or diagnostics.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Clean up redundant MCP workflow helpers [shardingsphere]

Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #39108:
URL: https://github.com/apache/shardingsphere/pull/39108


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org