[GitHub] [iceberg] rdblue commented on a diff in pull request #5129: Add source snapshot info to Puffin Blob metadata

[GitBox <gi...@apache.org>]

rdblue commented on code in PR #5129:
URL: https://github.com/apache/iceberg/pull/5129#discussion_r906319119


##########
core/src/main/java/org/apache/iceberg/puffin/FileMetadataParser.java:
##########
@@ -41,6 +41,8 @@ private FileMetadataParser() {
 
   private static final String TYPE = "type";
   private static final String FIELDS = "fields";
+  private static final String SOURCE_SNAPSHOT_ID = "source-snapshot-id";
+  private static final String SOURCE_SNAPSHOT_SEQUENCE_NUMBER = "source-snapshot-sequence-number";

Review Comment:
   What is the value of `source` here? What about just using `snapshot-id`?
   
   Also, it should just be `sequence-number` and not `snapshot-sequence-number`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org