You are viewing a plain text version of this content. The canonical link for it is here.
Posted to adffaces-issues@incubator.apache.org by "Tim McConnell (JIRA)" <ad...@incubator.apache.org> on 2007/04/30 15:16:15 UTC
[jira] Created: (ADFFACES-477) ADF-Faces plugin companion JIRA for
MYFACES-1598 (opened by Bruno Aranda)
ADF-Faces plugin companion JIRA for MYFACES-1598 (opened by Bruno Aranda)
-------------------------------------------------------------------------
Key: ADFFACES-477
URL: https://issues.apache.org/jira/browse/ADFFACES-477
Project: MyFaces ADF-Faces
Issue Type: Bug
Components: Plugins
Affects Versions: 2.0.0-incubating-plugins-SNAPSHOT
Reporter: Tim McConnell
Assigned To: Tim McConnell
Fix For: 2.0.0-incubating-plugins-SNAPSHOT
For "binding" the deferred-type must be 'javax.faces.component.UIComponent'
For "converter" the deferred-type must be 'javax.faces.convert.Converter'
Now the deferred-type tags in the tld for these attributes are empty (hence expeting java.jang.Object)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ADFFACES-477) ADF-Faces plugin companion JIRA
for MYFACES-1598 (opened by Bruno Aranda)
Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/ADFFACES-477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12492805 ]
Adam Winer commented on ADFFACES-477:
-------------------------------------
I think it'd be better to use type rather than name as the check here.
> ADF-Faces plugin companion JIRA for MYFACES-1598 (opened by Bruno Aranda)
> -------------------------------------------------------------------------
>
> Key: ADFFACES-477
> URL: https://issues.apache.org/jira/browse/ADFFACES-477
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Components: Plugins
> Affects Versions: 2.0.0-incubating-plugins-SNAPSHOT
> Reporter: Tim McConnell
> Assigned To: Tim McConnell
> Fix For: 2.0.0-incubating-plugins-SNAPSHOT
>
> Attachments: ADFFACES-477.patch
>
>
> For "binding" the deferred-type must be 'javax.faces.component.UIComponent'
> For "converter" the deferred-type must be 'javax.faces.convert.Converter'
> Now the deferred-type tags in the tld for these attributes are empty (hence expeting java.jang.Object)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ADFFACES-477) ADF-Faces plugin companion JIRA for
MYFACES-1598 (opened by Bruno Aranda)
Posted by "Tim McConnell (JIRA)" <ad...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/ADFFACES-477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim McConnell updated ADFFACES-477:
-----------------------------------
Status: Patch Available (was: Open)
> ADF-Faces plugin companion JIRA for MYFACES-1598 (opened by Bruno Aranda)
> -------------------------------------------------------------------------
>
> Key: ADFFACES-477
> URL: https://issues.apache.org/jira/browse/ADFFACES-477
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Components: Plugins
> Affects Versions: 2.0.0-incubating-plugins-SNAPSHOT
> Reporter: Tim McConnell
> Assigned To: Tim McConnell
> Fix For: 2.0.0-incubating-plugins-SNAPSHOT
>
>
> For "binding" the deferred-type must be 'javax.faces.component.UIComponent'
> For "converter" the deferred-type must be 'javax.faces.convert.Converter'
> Now the deferred-type tags in the tld for these attributes are empty (hence expeting java.jang.Object)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ADFFACES-477) ADF-Faces plugin companion JIRA for
MYFACES-1598 (opened by Bruno Aranda)
Posted by "Tim McConnell (JIRA)" <ad...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/ADFFACES-477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim McConnell updated ADFFACES-477:
-----------------------------------
Attachment: ADFFACES-477-2.patch
Hi Adam, I have followed your advice and removed the check for _CAN_COERCE. Also, since it is no longer used, I have removed the _CAN_COERCE hashset as well. It seems to work fine for MyFaces 1.2.
> ADF-Faces plugin companion JIRA for MYFACES-1598 (opened by Bruno Aranda)
> -------------------------------------------------------------------------
>
> Key: ADFFACES-477
> URL: https://issues.apache.org/jira/browse/ADFFACES-477
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Components: Plugins
> Affects Versions: 2.0.0-incubating-plugins-SNAPSHOT
> Reporter: Tim McConnell
> Assigned To: Tim McConnell
> Fix For: 2.0.0-incubating-plugins-SNAPSHOT
>
> Attachments: ADFFACES-477-2.patch, ADFFACES-477.patch
>
>
> For "binding" the deferred-type must be 'javax.faces.component.UIComponent'
> For "converter" the deferred-type must be 'javax.faces.convert.Converter'
> Now the deferred-type tags in the tld for these attributes are empty (hence expeting java.jang.Object)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ADFFACES-477) ADF-Faces plugin companion JIRA
for MYFACES-1598 (opened by Bruno Aranda)
Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/ADFFACES-477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12492808 ]
Adam Winer commented on ADFFACES-477:
-------------------------------------
Or removing the CAN_COERCE check altogether.
> ADF-Faces plugin companion JIRA for MYFACES-1598 (opened by Bruno Aranda)
> -------------------------------------------------------------------------
>
> Key: ADFFACES-477
> URL: https://issues.apache.org/jira/browse/ADFFACES-477
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Components: Plugins
> Affects Versions: 2.0.0-incubating-plugins-SNAPSHOT
> Reporter: Tim McConnell
> Assigned To: Tim McConnell
> Fix For: 2.0.0-incubating-plugins-SNAPSHOT
>
> Attachments: ADFFACES-477.patch
>
>
> For "binding" the deferred-type must be 'javax.faces.component.UIComponent'
> For "converter" the deferred-type must be 'javax.faces.convert.Converter'
> Now the deferred-type tags in the tld for these attributes are empty (hence expeting java.jang.Object)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ADFFACES-477) ADF-Faces plugin companion JIRA for
MYFACES-1598 (opened by Bruno Aranda)
Posted by "Tim McConnell (JIRA)" <ad...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/ADFFACES-477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tim McConnell updated ADFFACES-477:
-----------------------------------
Attachment: ADFFACES-477.patch
I changed ADFFACES to include the "type" value for the "binding" and "converter" property names, but this needs to be reviewed to ensure I'm fixing it properly on the ADFFACES pluging side. Thanks
> ADF-Faces plugin companion JIRA for MYFACES-1598 (opened by Bruno Aranda)
> -------------------------------------------------------------------------
>
> Key: ADFFACES-477
> URL: https://issues.apache.org/jira/browse/ADFFACES-477
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Components: Plugins
> Affects Versions: 2.0.0-incubating-plugins-SNAPSHOT
> Reporter: Tim McConnell
> Assigned To: Tim McConnell
> Fix For: 2.0.0-incubating-plugins-SNAPSHOT
>
> Attachments: ADFFACES-477.patch
>
>
> For "binding" the deferred-type must be 'javax.faces.component.UIComponent'
> For "converter" the deferred-type must be 'javax.faces.convert.Converter'
> Now the deferred-type tags in the tld for these attributes are empty (hence expeting java.jang.Object)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ADFFACES-477) ADF-Faces plugin companion JIRA for
MYFACES-1598 (opened by Bruno Aranda)
Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/ADFFACES-477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adam Winer updated ADFFACES-477:
--------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Removing _CAN_COERCE altogether did in fact introduce problems, like putting back String coercion, and without code changes breaks the use of converter ID strings for the "converter" property.
For now, hardcoding the two types UIComponent and Converter.
Also, added <coerceStrings> configuration property to (per-project) enable coercion of strings.
Finally, updated the component generation code so that "converter" wouldn't crap out - the trick is using getExpressionString() instead of getValue(null) to retrieve the string when ValueExpression.isLiteralText() is true.
> ADF-Faces plugin companion JIRA for MYFACES-1598 (opened by Bruno Aranda)
> -------------------------------------------------------------------------
>
> Key: ADFFACES-477
> URL: https://issues.apache.org/jira/browse/ADFFACES-477
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Components: Plugins
> Affects Versions: 2.0.0-incubating-plugins-SNAPSHOT
> Reporter: Tim McConnell
> Assigned To: Tim McConnell
> Fix For: 2.0.0-incubating-plugins-SNAPSHOT
>
> Attachments: ADFFACES-477-2.patch, ADFFACES-477.patch
>
>
> For "binding" the deferred-type must be 'javax.faces.component.UIComponent'
> For "converter" the deferred-type must be 'javax.faces.convert.Converter'
> Now the deferred-type tags in the tld for these attributes are empty (hence expeting java.jang.Object)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.