You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Felix-ming (via GitHub)" <gi...@apache.org> on 2026/10/06 08:36:18 UTC
[PR] Restore 100 and 365 Dag run limits in Grid view [airflow]
Felix-ming opened a new pull request, #74328:
URL: https://github.com/apache/airflow/pull/74328
## Summary
- Restore 100 and 365 in the Grid view DAG-run count selector.
- Keep the responsive Gantt options unchanged.
Closes #74291
## Testing
- Not run; this is a one-line UI option change.
## Visual verification
- Not run locally.
##### Was generative AI tooling used to co-author this PR?
- [X] Yes — OpenAI Codex
Generated-by: OpenAI Codex following the Airflow [GenAI contribution guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Restore 100 and 365 Dag run limits in Grid view [airflow]
Posted by "Felix-ming (via GitHub)" <gi...@apache.org>.
Felix-ming commented on code in PR #74328:
URL: https://github.com/apache/airflow/pull/74328#discussion_r4199539140
##########
airflow-core/src/airflow/ui/src/layouts/Details/PanelButtons.tsx:
##########
@@ -81,7 +81,7 @@ const getWidthBasedConfig = (width: number, enableResponsiveOptions: boolean) =>
{ limit: 10, min: 384, options: ["1", "5", "10"] }, // md: medium screens
{ limit: 5, min: 0, options: ["1", "5"] }, // sm: small screens and below
]
- : [{ limit: 5, min: 0, options: ["1", "5", "10", "25", "50"] }];
+ : [{ limit: 365, min: 0, options: ["1", "5", "10", "25", "50", "100", "365"] }];
Review Comment:
No — 365 is not the default. I updated the Grid default to remain at 5 in commit d0f1f1b; 100 and 365 are opt-in choices.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Restore 100 and 365 Dag run limits in Grid view [airflow]
Posted by "jroachgolf84 (via GitHub)" <gi...@apache.org>.
jroachgolf84 commented on code in PR #74328:
URL: https://github.com/apache/airflow/pull/74328#discussion_r4194940486
##########
airflow-core/src/airflow/ui/src/layouts/Details/PanelButtons.tsx:
##########
@@ -81,7 +81,7 @@ const getWidthBasedConfig = (width: number, enableResponsiveOptions: boolean) =>
{ limit: 10, min: 384, options: ["1", "5", "10"] }, // md: medium screens
{ limit: 5, min: 0, options: ["1", "5"] }, // sm: small screens and below
]
- : [{ limit: 5, min: 0, options: ["1", "5", "10", "25", "50"] }];
+ : [{ limit: 365, min: 0, options: ["1", "5", "10", "25", "50", "100", "365"] }];
Review Comment:
Do we want 365 to be the default? I'd stick with 5 or 10?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Restore 100 and 365 Dag run limits in Grid view [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #74328:
URL: https://github.com/apache/airflow/pull/74328#issuecomment-6012543409
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our [Contributors' Guide](https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example Dag that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Restore the 100-run option in Grid view [airflow]
Posted by "Felix-ming (via GitHub)" <gi...@apache.org>.
Felix-ming closed pull request #74328: Restore the 100-run option in Grid view
URL: https://github.com/apache/airflow/pull/74328
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Restore the 100-run option in Grid view [airflow]
Posted by "Felix-ming (via GitHub)" <gi...@apache.org>.
Felix-ming commented on PR #74328:
URL: https://github.com/apache/airflow/pull/74328#issuecomment-6024963997
Agreed. The repository's Grid-subtree benchmark measured a 1,370 ms median React commit at 100 runs versus 130 ms at 5 runs in the development-server/synthetic-data setup. That evidence doesn't justify restoring 100 without a performance improvement. I'll close this PR for now and keep the branch available to revisit once the Grid is made more scalable. Thanks for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Restore 100 and 365 Dag run limits in Grid view [airflow]
Posted by "Felix-ming (via GitHub)" <gi...@apache.org>.
Felix-ming commented on PR #74328:
URL: https://github.com/apache/airflow/pull/74328#issuecomment-6024179533
Update: I have narrowed this PR to restore the 100-run option only; 365 is intentionally omitted given its 3,349 ms median component mount in the benchmark above. The default remains 5. The 11 Grid pagination tests plus the affected UI ESLint and TypeScript checks passed before this one-item reduction; I cannot rerun them in this environment because Node/pnpm are unavailable, so I have not claimed new local test results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Restore the 100-run option in Grid view [airflow]
Posted by "Felix-ming (via GitHub)" <gi...@apache.org>.
Felix-ming commented on PR #74328:
URL: https://github.com/apache/airflow/pull/74328#issuecomment-6024739459
Update: I measured the repository's actual Grid subtree in Chromium (Grid, TaskInstancesColumn, GridTI, and related components), using mocked API responses, 40 leaf tasks, and populated successful task-instance summaries at a 1440×800 layout. Across five reloads at 5 runs: 200 rendered cells, 1,754 DOM nodes, and a final React Profiler commit median of 130 ms (106–133 ms). Across three reloads at 100 runs: 4,000 cells, 29,209 DOM nodes, and a final commit median of 1,370 ms (927–1,424 ms). This used Vite's development server and synthetic data; it excludes backend/network latency and is not a production end-to-end benchmark. It does show the full Grid subtree's commit cost is about 10.5× higher at 100. Given that result, I agree it does not justify restoring 100 as-is, and I won't describe the option as performance-validated. I will keep this PR scoped and won't add a broad virtualization refactor without maintainer direction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Restore the 100-run option in Grid view [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on PR #74328:
URL: https://github.com/apache/airflow/pull/74328#issuecomment-6024950931
Sounds like we should close this PR until we work on performance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Restore 100 and 365 Dag run limits in Grid view [airflow]
Posted by "Felix-ming (via GitHub)" <gi...@apache.org>.
Felix-ming commented on PR #74328:
URL: https://github.com/apache/airflow/pull/74328#issuecomment-6021719802
Thanks — agreed. I pushed d0f1f1b to keep the Grid default at 5 while retaining the larger choices. Locally, the Grid pagination tests (11) and the affected UI ESLint/TypeScript checks pass. I have not run a representative browser benchmark with a 365-run DAG, so I cannot claim the larger options are performance-validated. Would you prefer that I remove 100/365 from this PR until that data is available, or would measured local results be sufficient to keep them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Restore 100 and 365 Dag run limits in Grid view [airflow]
Posted by "Felix-ming (via GitHub)" <gi...@apache.org>.
Felix-ming commented on PR #74328:
URL: https://github.com/apache/airflow/pull/74328#issuecomment-6022775325
Following up with a local Chromium component-level benchmark. I rendered the production TaskInstancesColumn components for a 40-row visible window, with one warm-up and three measured mounts per setting. Median synchronous React mount times were: 5 runs: 47 ms (1,407 DOM nodes / 200 task cells); 100 runs: 900 ms (28,102 DOM nodes / 4,000 cells); 365 runs: 3,349 ms (102,567 DOM nodes / 14,600 cells).
This is not an end-to-end Grid page benchmark: it excludes API fetching/streaming and the rest of the page, so please treat it as an isolated rendering measurement rather than a production latency guarantee. The 365-run option does have a substantial mount cost. Would you consider this enough evidence to keep both options while retaining the default of 5, or would you prefer a horizontal virtualization/performance change first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org