[jira] [Commented] (SPARK-3345) Do correct parameters for ShuffleFileGroup

["Apache Spark (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SPARK-3345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14118082#comment-14118082 ] 

Apache Spark commented on SPARK-3345:
-------------------------------------

User 'viirya' has created a pull request for this issue:
https://github.com/apache/spark/pull/2235

> Do correct parameters for ShuffleFileGroup
> ------------------------------------------
>
>                 Key: SPARK-3345
>                 URL: https://issues.apache.org/jira/browse/SPARK-3345
>             Project: Spark
>          Issue Type: Bug
>            Reporter: Liang-Chi Hsieh
>            Priority: Minor
>
> In the method newFileGroup of class FileShuffleBlockManager, the parameters for creating new ShuffleFileGroup object is in wrong order.
> Wrong: new ShuffleFileGroup(fileId, shuffleId, files)
> Corrent: new ShuffleFileGroup(shuffleId, fileId, files)
> Because in current codes, the parameters shuffleId and fileId are not used. So it doesn't cause problem now. However it should be corrected for readability and avoid future problem.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org