You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "swebb2066 (via GitHub)" <gi...@apache.org> on 2026/04/06 04:11:33 UTC
[PR] Improve the ByteBuffer interface in the next ABI version [logging-log4cxx]
swebb2066 opened a new pull request, #625:
URL: https://github.com/apache/logging-log4cxx/pull/625
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve the ByteBuffer interface in the next ABI version [logging-log4cxx]
Posted by "swebb2066 (via GitHub)" <gi...@apache.org>.
swebb2066 merged PR #625:
URL: https://github.com/apache/logging-log4cxx/pull/625
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve the ByteBuffer interface in the next ABI version [logging-log4cxx]
Posted by "rm5248 (via GitHub)" <gi...@apache.org>.
rm5248 commented on code in PR #625:
URL: https://github.com/apache/logging-log4cxx/pull/625#discussion_r3042337719
##########
src/main/include/log4cxx/helpers/bytebuffer.h:
##########
@@ -28,31 +28,82 @@ namespace helpers
{
/**
-* A byte buffer.
+* An area of memory, a cursor into that memory and a count of remaining bytes.
+* It does not own the memory, so does not allocate or free memory.
+* The user must ensure the lifetime of the memory exceeds the lifeime of the class instance.
*/
class LOG4CXX_EXPORT ByteBuffer
Review Comment:
for the next ABI version if we go to C++20 it sounds like `std::span` may fit several of the use cases of this class. thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve the ByteBuffer interface in the next ABI version [logging-log4cxx]
Posted by "swebb2066 (via GitHub)" <gi...@apache.org>.
swebb2066 commented on code in PR #625:
URL: https://github.com/apache/logging-log4cxx/pull/625#discussion_r3042441236
##########
src/main/include/log4cxx/helpers/bytebuffer.h:
##########
@@ -28,31 +28,82 @@ namespace helpers
{
/**
-* A byte buffer.
+* An area of memory, a cursor into that memory and a count of remaining bytes.
+* It does not own the memory, so does not allocate or free memory.
+* The user must ensure the lifetime of the memory exceeds the lifeime of the class instance.
*/
class LOG4CXX_EXPORT ByteBuffer
Review Comment:
ByteBuffer has the extra functionality of a cursor, so std::span is not a drop in replacement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org