You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/11/13 07:09:16 UTC
[GitHub] [spark] hgs19921112 opened a new pull request #34492: [SPARK-37216][SQL] Add the Hive macro functionality to SparkSQL
hgs19921112 opened a new pull request #34492:
URL: https://github.com/apache/spark/pull/34492
### What changes were proposed in this pull request?
Add the Hive macro functionality to SparkSQL
### Why are the changes needed?
Some Hive sql can move to SparkSQL Smoothly
### Does this PR introduce _any_ user-facing change?
Some new DDL like 'create temparory macro ...'
### How was this patch tested?
unit test
Authored-by: hgs19921112 <ha...@gmail.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] xkrogen commented on pull request #34492: [SPARK-37216][SQL] Add the Hive macro functionality to SparkSQL
Posted by GitBox <gi...@apache.org>.
xkrogen commented on pull request #34492:
URL: https://github.com/apache/spark/pull/34492#issuecomment-964360209
This seems to have some overlap with the recent functionality announced by Databricks (as an internal/proprietary feature): https://databricks.com/blog/2021/10/20/introducing-sql-user-defined-functions.html
Is that understanding correct? Can you compare?
I am wondering if, similar to the Databricks feature, OSS Spark should have a more holistic way of handling this as opposed to copying Hive's syntax for a limited subset of the functionality.
cc @mridulm @wmoustafa @shardulm94
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hgs19921112 commented on pull request #34492: [SPARK-37216][SQL] Add the Hive macro functionality to SparkSQL
Posted by GitBox <gi...@apache.org>.
hgs19921112 commented on pull request #34492:
URL: https://github.com/apache/spark/pull/34492#issuecomment-964687521
> This seems to have some overlap with the recent functionality announced by Databricks (as an internal/proprietary feature): https://databricks.com/blog/2021/10/20/introducing-sql-user-defined-functions.html Is that understanding correct? Can you compare? I am wondering if, similar to the Databricks feature, OSS Spark should have a more holistic way of handling this as opposed to copying Hive's syntax for a limited subset of the functionality.
>
> cc @mridulm @wmoustafa @shardulm94
You are right . The functionality in Databricks's Spark is more powerful than this.I did not know about that before you mentioned it.Mybe this is excess.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hgs19921112 commented on pull request #34492: [SPARK-37216][SQL] Add the Hive macro functionality to SparkSQL
Posted by GitBox <gi...@apache.org>.
hgs19921112 commented on pull request #34492:
URL: https://github.com/apache/spark/pull/34492#issuecomment-962977940
Can anayone have a see? If this pr is useless , I will close it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34492: [SPARK-37216] Add the Hive macro functionality to SparkSQL
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34492:
URL: https://github.com/apache/spark/pull/34492#issuecomment-961791781
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hgs19921112 closed pull request #34492: [SPARK-37216][SQL] Add the Hive macro functionality to SparkSQL
Posted by GitBox <gi...@apache.org>.
hgs19921112 closed pull request #34492:
URL: https://github.com/apache/spark/pull/34492
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34492: [SPARK-37216] Add the Hive macro functionality to SparkSQL
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34492:
URL: https://github.com/apache/spark/pull/34492#issuecomment-961791781
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34492: [SPARK-37216] Add the Hive macro functionality to SparkSQL
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34492:
URL: https://github.com/apache/spark/pull/34492#issuecomment-961791781
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hgs19921112 closed pull request #34492: [SPARK-37216][SQL] Add the Hive macro functionality to SparkSQL
Posted by GitBox <gi...@apache.org>.
hgs19921112 closed pull request #34492:
URL: https://github.com/apache/spark/pull/34492
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org