You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/06/15 17:48:24 UTC

[GitHub] [tvm] kparzysz-quic commented on pull request #11731: [MetaSchedule] Include te/tensor.h instead of forward declaring te::T…

kparzysz-quic commented on PR #11731:
URL: https://github.com/apache/tvm/pull/11731#issuecomment-1156761665

   It's actually a good practice to use forward declarations when the header is not needed.  The problem is that in some cases the types must me complete, in this case it was because there was `std::enable_if` used in the declaration of `Array`.  The trait checked in there required the checked type to be complete.
   What I find surprising that it works with the compilers we use in CI.  I'm not sure of this is because of newer clang, or because I'm using libc++.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org