You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by minahlee <gi...@git.apache.org> on 2016/06/04 02:04:15 UTC
[GitHub] incubator-zeppelin pull request #959: [ZEPPELIN-951] Update cron expression ...
GitHub user minahlee opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/959
[ZEPPELIN-951] Update cron expression link and fix broken cron container style
### What is this PR for?
Update cron expression link and fix broken cron container style
### What type of PR is it?
Bug Fix
### What is the Jira issue?
ZEPPELIN-951
### Screenshots (if appropriate)
**Before**
<img width="429" alt="screen shot 2016-06-03 at 7 01 00 pm" src="https://cloud.githubusercontent.com/assets/8503346/15796973/e19a492a-29bd-11e6-89dd-cd69310e077d.png">
**After**
<img width="304" alt="screen shot 2016-06-03 at 7 00 39 pm" src="https://cloud.githubusercontent.com/assets/8503346/15796974/e73c4ac2-29bd-11e6-8f9a-0e95ab69d2a6.png">
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/minahlee/incubator-zeppelin ZEPPELIN-951
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/959.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #959
----
commit 82d8e9ad28c331e677b518d89be04a512709c2d4
Author: Mina Lee <mi...@nflabs.com>
Date: 2016-06-04T02:02:12Z
Update cron expression link and fix broken cron container style
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #959: [ZEPPELIN-951] Update cron expression link an...
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/959
LGTM. Will Merge this if no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #959: [ZEPPELIN-951] Update cron expression link an...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/959
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request #959: [ZEPPELIN-951] Update cron expression ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/959
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #959: [ZEPPELIN-951] Update cron expression link an...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/959
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #959: [ZEPPELIN-951] Update cron expression link an...
Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/959
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #959: [ZEPPELIN-951] Update cron expression link an...
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/959
Same test failure is already reported by @bzz in https://issues.apache.org/jira/browse/ZEPPELIN-942
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #959: [ZEPPELIN-951] Update cron expression link an...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/959
Hi @minahlee,
This CI failure is fixed with #958. Can you rebase with master and re-trigger ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #959: [ZEPPELIN-951] Update cron expression link an...
Posted by minahlee <gi...@git.apache.org>.
Github user minahlee commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/959
@prabhjyotsingh Test is passing now! Thanks for taking care of it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---