[GitHub] lanking520 commented on a change in pull request #13189: [WIP] Fix scaladoc build errors

[GitBox <gi...@apache.org>]

lanking520 commented on a change in pull request #13189: [WIP] Fix scaladoc build errors
URL: https://github.com/apache/incubator-mxnet/pull/13189#discussion_r232142826
 
 

 ##########
 File path: docs/mxdoc.py
 ##########
 @@ -109,7 +109,13 @@ def build_scala_docs(app):
     """build scala doc and then move the outdir"""
     scala_path = app.builder.srcdir + '/../scala-package'
     # scaldoc fails on some apis, so exit 0 to pass the check
-    _run_cmd('cd ' + scala_path + '; scaladoc `find . -type f -name "*.scala" | egrep \"\/core|\/infer\" | egrep -v \"Suite\"`; exit 0')
+    scala_doc_sources = 'find . -type f -name "*.scala" | egrep \"\.\/core|\.\/infer\" | egrep -v \"Suite\"'
+    scala_doc_classpath = ':'.join([
+        '`find native -name "*.jar" | grep "target/lib/" | tr "\n" ":" `',
+        '`find macros -name "*-SNAPSHOT.jar" | tr "\n" ":" `'
 
 Review comment:
   Not sure why include macros SNAPSHOT?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services