You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2019/12/23 12:40:28 UTC
[GitHub] [cloudstack] nvazquez commented on a change in pull request #3731:
[WIP DO NOT MERGE] System VM Template Direct Download Support
nvazquez commented on a change in pull request #3731: [WIP DO NOT MERGE] System VM Template Direct Download Support
URL: https://github.com/apache/cloudstack/pull/3731#discussion_r360874557
##########
File path: core/src/main/java/org/apache/cloudstack/agent/directdownload/HttpDirectDownloadCommand.java
##########
@@ -18,14 +18,16 @@
*/
package org.apache.cloudstack.agent.directdownload;
-import org.apache.cloudstack.storage.to.PrimaryDataStoreTO;
-
import java.util.Map;
+import org.apache.cloudstack.storage.to.PrimaryDataStoreTO;
+
public class HttpDirectDownloadCommand extends DirectDownloadCommand {
- public HttpDirectDownloadCommand(String url, Long templateId, PrimaryDataStoreTO destPool, String checksum, Map<String, String> headers) {
+ public HttpDirectDownloadCommand(String url, Long templateId, PrimaryDataStoreTO destPool, String checksum, Map<String, String> headers, int connectTimeout, int soTimeout) {
super(url, templateId, destPool, checksum, headers);
+ setConnectTimeout(connectTimeout);
Review comment:
Can these be set on the DrectDownloadCommand constructor?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services