You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by p32blo <gi...@git.apache.org> on 2018/03/01 10:32:38 UTC
[GitHub] qpid-proton pull request #137: [cpp] Fix update method missing 'name' variab...
GitHub user p32blo opened a pull request:
https://github.com/apache/qpid-proton/pull/137
[cpp] Fix update method missing 'name' variable
The `name` property in the sender and receiver is not being updated correctly when passed to the `open_sender` and `open_receiver`.
Here is a simple example demonstrating the problem:
```cpp
#include <proton/sender_options.hpp>
#include <proton/receiver_options.hpp>
#include <proton/container.hpp>
#include <iostream>
int main()
{
proton::container c;
proton::sender_options so;
proton::receiver_options ro;
so.name("qpid");
ro.name("qpid");
proton::sender sender = c.open_sender("", so);
proton::receiver receiver = c.open_receiver("", ro);
std::cout << sender.name() << std::endl;
std::cout << receiver.name() << std::endl;
}
```
The output is currently a random uuid, but it should be "qpid" in both cases.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/p32blo/qpid-proton master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-proton/pull/137.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #137
----
commit 69a9f91627ccc997337cab5f191f2d1c80ca10f3
Author: André Oliveira <an...@...>
Date: 2018-03-01T10:15:30Z
[cpp] Fix update method missing 'name' variable
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-proton pull request #137: [cpp] Fix update method missing 'name' variab...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/qpid-proton/pull/137
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-proton issue #137: [cpp] Fix update method missing 'name' variable
Posted by astitcher <gi...@git.apache.org>.
Github user astitcher commented on the issue:
https://github.com/apache/qpid-proton/pull/137
Thanks for this fix - I will commit it when we have some tests for this bug to prevent any regressions.
If you want to get this into master quicker then I suggest you write a simple test for this bug which fails without this fix and succeeds with the fix.
It looks like there isn't an obvious existing unit test file that this would fit into sadly, so it might mean creating a new one - mostly by copying an existing one.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org