[GitHub] [ignite-3] ibessonov commented on a diff in pull request #2619: IGNTIE-20339 Get rid of legacy IndexEvent, TableEvent and SchemaEvent

["ibessonov (via GitHub)" <gi...@apache.org>]

ibessonov commented on code in PR #2619:
URL: https://github.com/apache/ignite-3/pull/2619#discussion_r1337087402


##########
modules/index/src/main/java/org/apache/ignite/internal/index/IndexManager.java:
##########
@@ -64,7 +61,7 @@
  * as well as managing indexes' lifecycle.
  */
 // TODO: IGNITE-19082 Delete this class
-public class IndexManager extends AbstractEventProducer<IndexEvent, IndexEventParameters> implements IgniteComponent {
+public class IndexManager implements IgniteComponent {

Review Comment:
   > Thus, IndexManager can just call builder methods directly.
   
   This is precisely my concern, I don't want index manager to depend on our internal stuff. Events allows us to remove such unnecessary dependencies.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org