[GitHub] [druid] gianm commented on pull request #14334: use the latest datasketches-java-4.0.0

["gianm (via GitHub)" <gi...@apache.org>]

gianm commented on PR #14334:
URL: https://github.com/apache/druid/pull/14334#issuecomment-1560266924

   Looks pretty clean. Thanks for the patch!
   
   Reading https://github.com/apache/datasketches-java/blob/master/src/main/java/org/apache/datasketches/quantilescommon/QuantileSearchCriteria.java, I don't immediately see situations where the difference between `inclusive` and `exclusive` would be meaningful. Do you know of situations where the difference is in fact important? That'd help understand the potential impact of the change.
   
   I also wonder, if the old behavior was `exclusive`, then why change it? I mean, why not have things always be `exclusive` post this patch as well? Is `inclusive` fundamentally better in some way?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org