You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/01/21 06:11:58 UTC

[GitHub] [pulsar] merlimat commented on a change in pull request #9253: [Spotbugs] Enable spotbugs in pulsar-metadata

merlimat commented on a change in pull request #9253:
URL: https://github.com/apache/pulsar/pull/9253#discussion_r561625005



##########
File path: pulsar-metadata/src/main/java/org/apache/pulsar/metadata/api/GetResult.java
##########
@@ -26,11 +26,20 @@
 @Data
 public class GetResult {
 
+    public GetResult(byte[] value, Stat stat){
+        this.value = value.clone();

Review comment:
       While I understand the immutability aspect, making 2 extra copies and allocations of the value array it's overkill for this scenario.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org