You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by bvbharatk <gi...@git.apache.org> on 2017/02/24 05:51:54 UTC

[GitHub] cloudstack pull request #1971: CLOUDSTACK-9726 Update state is not changed t...

GitHub user bvbharatk opened a pull request:

    https://github.com/apache/cloudstack/pull/1971

    CLOUDSTACK-9726 Update state is not changed to UPDATE_FAILED in case \u2026

    \u2026when Host is put in Maintenance Mode.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bvbharatk/cloudstack CLOUDSTACK-9726

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1971.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1971
    
----
commit 670f24ec5dc067ab1e7a29f12c8cd4a709545c24
Author: Bharat Kumar <bh...@citrix.com>
Date:   2016-01-04T13:06:28Z

    CLOUDSTACK-9726 Update state is not changed to UPDATE_FAILED in case when Host is put in Maintenance Mode.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1971: CLOUDSTACK-9726 Update state is not changed to UPDAT...

Posted by borisstoyanov <gi...@git.apache.org>.
Github user borisstoyanov commented on the issue:

    https://github.com/apache/cloudstack/pull/1971
  
    @bvbharatk is there unit tests for this change?
    @blueorangutan package


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1971: CLOUDSTACK-9726 Update state is not changed to UPDAT...

Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:

    https://github.com/apache/cloudstack/pull/1971
  
    @borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1971: CLOUDSTACK-9726 Update state is not changed to UPDAT...

Posted by borisstoyanov <gi...@git.apache.org>.
Github user borisstoyanov commented on the issue:

    https://github.com/apache/cloudstack/pull/1971
  
    @blueorangutan test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1971: CLOUDSTACK-9726 Update state is not changed to UPDAT...

Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:

    https://github.com/apache/cloudstack/pull/1971
  
    <b>Trillian test result (tid-891)</b>
    Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
    Total time taken: 32576 seconds
    Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1971-t891-kvm-centos7.zip
    Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
    Intermitten failure detected: /marvin/tests/smoke/test_snapshots.py
    Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
    Test completed. 46 look ok, 3 have error(s)
    
    
    Test | Result | Time (s) | Test File
    --- | --- | --- | ---
    test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers | `Failure` | 349.03 | test_vpc_redundant.py
    test_02_redundant_VPC_default_routes | `Failure` | 863.17 | test_vpc_redundant.py
    test_04_rvpc_privategw_static_routes | `Failure` | 314.00 | test_privategw_acl.py
    test_02_list_snapshots_with_removed_data_store | `Error` | 0.04 | test_snapshots.py
    test_01_vpc_site2site_vpn | Success | 159.96 | test_vpc_vpn.py
    test_01_vpc_remote_access_vpn | Success | 65.84 | test_vpc_vpn.py
    test_01_redundant_vpc_site2site_vpn | Success | 244.90 | test_vpc_vpn.py
    test_02_VPC_default_routes | Success | 288.23 | test_vpc_router_nics.py
    test_01_VPC_nics_after_destroy | Success | 523.34 | test_vpc_router_nics.py
    test_05_rvpc_multi_tiers | Success | 500.56 | test_vpc_redundant.py
    test_04_rvpc_network_garbage_collector_nics | Success | 1325.16 | test_vpc_redundant.py
    test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Success | 1284.43 | test_vpc_redundant.py
    test_09_delete_detached_volume | Success | 156.30 | test_volumes.py
    test_08_resize_volume | Success | 156.07 | test_volumes.py
    test_07_resize_fail | Success | 156.12 | test_volumes.py
    test_06_download_detached_volume | Success | 156.24 | test_volumes.py
    test_05_detach_volume | Success | 150.59 | test_volumes.py
    test_04_delete_attached_volume | Success | 150.90 | test_volumes.py
    test_03_download_attached_volume | Success | 156.00 | test_volumes.py
    test_02_attach_volume | Success | 124.05 | test_volumes.py
    test_01_create_volume | Success | 714.12 | test_volumes.py
    test_03_delete_vm_snapshots | Success | 275.15 | test_vm_snapshots.py
    test_02_revert_vm_snapshots | Success | 100.69 | test_vm_snapshots.py
    test_01_create_vm_snapshots | Success | 158.75 | test_vm_snapshots.py
    test_deploy_vm_multiple | Success | 262.14 | test_vm_life_cycle.py
    test_deploy_vm | Success | 0.02 | test_vm_life_cycle.py
    test_advZoneVirtualRouter | Success | 0.02 | test_vm_life_cycle.py
    test_10_attachAndDetach_iso | Success | 26.70 | test_vm_life_cycle.py
    test_09_expunge_vm | Success | 185.21 | test_vm_life_cycle.py
    test_08_migrate_vm | Success | 40.68 | test_vm_life_cycle.py
    test_07_restore_vm | Success | 0.08 | test_vm_life_cycle.py
    test_06_destroy_vm | Success | 125.64 | test_vm_life_cycle.py
    test_03_reboot_vm | Success | 125.68 | test_vm_life_cycle.py
    test_02_start_vm | Success | 10.13 | test_vm_life_cycle.py
    test_01_stop_vm | Success | 40.25 | test_vm_life_cycle.py
    test_CreateTemplateWithDuplicateName | Success | 55.40 | test_templates.py
    test_08_list_system_templates | Success | 0.02 | test_templates.py
    test_07_list_public_templates | Success | 0.03 | test_templates.py
    test_05_template_permissions | Success | 0.04 | test_templates.py
    test_04_extract_template | Success | 5.11 | test_templates.py
    test_03_delete_template | Success | 5.08 | test_templates.py
    test_02_edit_template | Success | 90.07 | test_templates.py
    test_01_create_template | Success | 25.25 | test_templates.py
    test_10_destroy_cpvm | Success | 161.55 | test_ssvm.py
    test_09_destroy_ssvm | Success | 163.61 | test_ssvm.py
    test_08_reboot_cpvm | Success | 131.46 | test_ssvm.py
    test_07_reboot_ssvm | Success | 133.50 | test_ssvm.py
    test_06_stop_cpvm | Success | 131.63 | test_ssvm.py
    test_05_stop_ssvm | Success | 133.60 | test_ssvm.py
    test_04_cpvm_internals | Success | 1.22 | test_ssvm.py
    test_03_ssvm_internals | Success | 3.24 | test_ssvm.py
    test_02_list_cpvm_vm | Success | 0.09 | test_ssvm.py
    test_01_list_sec_storage_vm | Success | 0.10 | test_ssvm.py
    test_01_snapshot_root_disk | Success | 10.92 | test_snapshots.py
    test_04_change_offering_small | Success | 239.35 | test_service_offerings.py
    test_03_delete_service_offering | Success | 0.03 | test_service_offerings.py
    test_02_edit_service_offering | Success | 0.04 | test_service_offerings.py
    test_01_create_service_offering | Success | 0.08 | test_service_offerings.py
    test_02_sys_template_ready | Success | 0.09 | test_secondary_storage.py
    test_01_sys_vm_start | Success | 0.14 | test_secondary_storage.py
    test_09_reboot_router | Success | 35.24 | test_routers.py
    test_08_start_router | Success | 30.21 | test_routers.py
    test_07_stop_router | Success | 10.12 | test_routers.py
    test_06_router_advanced | Success | 0.04 | test_routers.py
    test_05_router_basic | Success | 0.03 | test_routers.py
    test_04_restart_network_wo_cleanup | Success | 5.67 | test_routers.py
    test_03_restart_network_cleanup | Success | 60.55 | test_routers.py
    test_02_router_internal_adv | Success | 1.04 | test_routers.py
    test_01_router_internal_basic | Success | 0.56 | test_routers.py
    test_router_dns_guestipquery | Success | 76.72 | test_router_dns.py
    test_router_dns_externalipquery | Success | 0.04 | test_router_dns.py
    test_router_dhcphosts | Success | 277.69 | test_router_dhcphosts.py
    test_router_dhcp_opts | Success | 21.55 | test_router_dhcphosts.py
    test_01_updatevolumedetail | Success | 0.07 | test_resource_detail.py
    test_01_reset_vm_on_reboot | Success | 145.83 | test_reset_vm_on_reboot.py
    test_createRegion | Success | 0.03 | test_regions.py
    test_create_pvlan_network | Success | 5.15 | test_pvlan.py
    test_dedicatePublicIpRange | Success | 0.29 | test_public_ip_range.py
    test_03_vpc_privategw_restart_vpc_cleanup | Success | 484.42 | test_privategw_acl.py
    test_02_vpc_privategw_static_routes | Success | 358.47 | test_privategw_acl.py
    test_01_vpc_privategw_acl | Success | 81.52 | test_privategw_acl.py
    test_01_primary_storage_nfs | Success | 35.88 | test_primary_storage.py
    test_createPortablePublicIPRange | Success | 15.14 | test_portable_publicip.py
    test_createPortablePublicIPAcquire | Success | 15.30 | test_portable_publicip.py
    test_isolate_network_password_server | Success | 89.25 | test_password_server.py
    test_UpdateStorageOverProvisioningFactor | Success | 0.09 | test_over_provisioning.py
    test_oobm_zchange_password | Success | 30.52 | test_outofbandmanagement.py
    test_oobm_multiple_mgmt_server_ownership | Success | 16.25 | test_outofbandmanagement.py
    test_oobm_issue_power_status | Success | 10.26 | test_outofbandmanagement.py
    test_oobm_issue_power_soft | Success | 15.24 | test_outofbandmanagement.py
    test_oobm_issue_power_reset | Success | 10.23 | test_outofbandmanagement.py
    test_oobm_issue_power_on | Success | 15.27 | test_outofbandmanagement.py
    test_oobm_issue_power_off | Success | 15.24 | test_outofbandmanagement.py
    test_oobm_issue_power_cycle | Success | 15.38 | test_outofbandmanagement.py
    test_oobm_enabledisable_across_clusterzones | Success | 82.62 | test_outofbandmanagement.py
    test_oobm_enable_feature_valid | Success | 0.14 | test_outofbandmanagement.py
    test_oobm_enable_feature_invalid | Success | 0.08 | test_outofbandmanagement.py
    test_oobm_disable_feature_valid | Success | 5.13 | test_outofbandmanagement.py
    test_oobm_disable_feature_invalid | Success | 0.08 | test_outofbandmanagement.py
    test_oobm_configure_invalid_driver | Success | 0.06 | test_outofbandmanagement.py
    test_oobm_configure_default_driver | Success | 0.06 | test_outofbandmanagement.py
    test_oobm_background_powerstate_sync | Success | 29.33 | test_outofbandmanagement.py
    test_extendPhysicalNetworkVlan | Success | 15.26 | test_non_contigiousvlan.py
    test_01_nic | Success | 418.13 | test_nic.py
    test_releaseIP | Success | 242.58 | test_network.py
    test_reboot_router | Success | 412.99 | test_network.py
    test_public_ip_user_account | Success | 10.18 | test_network.py
    test_public_ip_admin_account | Success | 40.18 | test_network.py
    test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Success | 66.71 | test_network.py
    test_network_rules_acquired_public_ip_2_nat_rule | Success | 61.59 | test_network.py
    test_network_rules_acquired_public_ip_1_static_nat_rule | Success | 124.04 | test_network.py
    test_delete_account | Success | 293.56 | test_network.py
    test_02_port_fwd_on_non_src_nat | Success | 55.47 | test_network.py
    test_01_port_fwd_on_src_nat | Success | 111.65 | test_network.py
    test_nic_secondaryip_add_remove | Success | 227.28 | test_multipleips_per_nic.py
    login_test_saml_user | Success | 17.78 | test_login.py
    test_assign_and_removal_lb | Success | 133.11 | test_loadbalance.py
    test_02_create_lb_rule_non_nat | Success | 187.06 | test_loadbalance.py
    test_01_create_lb_rule_src_nat | Success | 217.80 | test_loadbalance.py
    test_03_list_snapshots | Success | 0.06 | test_list_ids_parameter.py
    test_02_list_templates | Success | 0.03 | test_list_ids_parameter.py
    test_01_list_volumes | Success | 0.02 | test_list_ids_parameter.py
    test_07_list_default_iso | Success | 0.04 | test_iso.py
    test_05_iso_permissions | Success | 0.04 | test_iso.py
    test_04_extract_Iso | Success | 5.12 | test_iso.py
    test_03_delete_iso | Success | 95.18 | test_iso.py
    test_02_edit_iso | Success | 0.04 | test_iso.py
    test_01_create_iso | Success | 20.68 | test_iso.py
    test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | Success | 198.00 | test_internal_lb.py
    test_03_vpc_internallb_haproxy_stats_on_all_interfaces | Success | 137.63 | test_internal_lb.py
    test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | Success | 514.47 | test_internal_lb.py
    test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | Success | 442.13 | test_internal_lb.py
    test_dedicateGuestVlanRange | Success | 10.18 | test_guest_vlan_range.py
    test_UpdateConfigParamWithScope | Success | 0.09 | test_global_settings.py
    test_rolepermission_lifecycle_update | Success | 5.82 | test_dynamicroles.py
    test_rolepermission_lifecycle_list | Success | 5.75 | test_dynamicroles.py
    test_rolepermission_lifecycle_delete | Success | 5.60 | test_dynamicroles.py
    test_rolepermission_lifecycle_create | Success | 5.68 | test_dynamicroles.py
    test_rolepermission_lifecycle_concurrent_updates | Success | 5.68 | test_dynamicroles.py
    test_role_lifecycle_update_role_inuse | Success | 5.61 | test_dynamicroles.py
    test_role_lifecycle_update | Success | 10.70 | test_dynamicroles.py
    test_role_lifecycle_list | Success | 5.62 | test_dynamicroles.py
    test_role_lifecycle_delete | Success | 10.64 | test_dynamicroles.py
    test_role_lifecycle_create | Success | 5.62 | test_dynamicroles.py
    test_role_inuse_deletion | Success | 5.58 | test_dynamicroles.py
    test_role_account_acls_multiple_mgmt_servers | Success | 6.91 | test_dynamicroles.py
    test_role_account_acls | Success | 7.04 | test_dynamicroles.py
    test_default_role_deletion | Success | 5.79 | test_dynamicroles.py
    test_04_create_fat_type_disk_offering | Success | 0.05 | test_disk_offerings.py
    test_03_delete_disk_offering | Success | 0.03 | test_disk_offerings.py
    test_02_edit_disk_offering | Success | 0.04 | test_disk_offerings.py
    test_02_create_sparse_type_disk_offering | Success | 0.05 | test_disk_offerings.py
    test_01_create_disk_offering | Success | 0.09 | test_disk_offerings.py
    test_deployvm_userdispersing | Success | 20.48 | test_deploy_vms_with_varied_deploymentplanners.py
    test_deployvm_userconcentrated | Success | 30.45 | test_deploy_vms_with_varied_deploymentplanners.py
    test_deployvm_firstfit | Success | 50.44 | test_deploy_vms_with_varied_deploymentplanners.py
    test_deployvm_userdata_post | Success | 10.27 | test_deploy_vm_with_userdata.py
    test_deployvm_userdata | Success | 51.19 | test_deploy_vm_with_userdata.py
    test_02_deploy_vm_root_resize | Success | 5.66 | test_deploy_vm_root_resize.py
    test_01_deploy_vm_root_resize | Success | 5.66 | test_deploy_vm_root_resize.py
    test_00_deploy_vm_root_resize | Success | 211.78 | test_deploy_vm_root_resize.py
    test_deploy_vm_from_iso | Success | 206.88 | test_deploy_vm_iso.py
    test_DeployVmAntiAffinityGroup | Success | 66.42 | test_affinity_groups.py
    test_change_service_offering_for_vm_with_snapshots | Skipped | 0.00 | test_vm_snapshots.py
    test_01_test_vm_volume_snapshot | Skipped | 0.00 | test_vm_snapshots.py
    test_06_copy_template | Skipped | 0.00 | test_templates.py
    test_static_role_account_acls | Skipped | 0.02 | test_staticroles.py
    test_11_ss_nfs_version_on_ssvm | Skipped | 0.02 | test_ssvm.py
    test_01_scale_vm | Skipped | 0.00 | test_scale_vm.py
    test_01_primary_storage_iscsi | Skipped | 0.03 | test_primary_storage.py
    test_nested_virtualization_vmware | Skipped | 0.00 | test_nested_virtualization.py
    test_06_copy_iso | Skipped | 0.00 | test_iso.py
    test_deploy_vgpu_enabled_vm | Skipped | 0.02 | test_deploy_vgpu_enabled_vm.py
    test_3d_gpu_support | Skipped | 0.02 | test_deploy_vgpu_enabled_vm.py



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1971: CLOUDSTACK-9726 Update state is not changed to UPDAT...

Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:

    https://github.com/apache/cloudstack/pull/1971
  
    Packaging result: \u2714centos6 \u2714centos7 \u2714debian. JID-533


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1971: CLOUDSTACK-9726 Update state is not changed to UPDAT...

Posted by bvbharatk <gi...@git.apache.org>.
Github user bvbharatk commented on the issue:

    https://github.com/apache/cloudstack/pull/1971
  
    @borisstoyanov 
    ran test/integration/component/maint/test_redundant_router.py .
    
    Test create network with non-default guest cidr with redundant routers ... === TestName: test_createRvRNetwork | Status : SUCCESS ===
    ok
    Test create RvR supported network offering ... === TestName: test_createRvRNetworkOffering | Status : SUCCESS ===
    ok
    Test redundant router internals ... === TestName: test_redundantVR_internals | Status : SUCCESS ===
    ok
    Test stop master RVR ... === TestName: test_01_stopMasterRvR | Status : SUCCESS ===
    ok
    Test stop backup RVR ... === TestName: test_02_stopBackupRvR | Status : SUCCESS ===
    ok
    Test reboot master RVR ... === TestName: test_03_rebootMasterRvR | Status : SUCCESS ===
    ok
    Test reboot backup RVR ... === TestName: test_04_rebootBackupRvR | Status : SUCCESS ===
    ok
    Test stop backup RVR and start instance ... === TestName: test_05_stopBackupRvR_startInstance | Status : SUCCESS ===
    ok
    Test update network and check if VRs are updated in sequence ... === TestName: test_06_updateVRs_in_sequence | Status : SUCCESS ===
    ok


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1971: CLOUDSTACK-9726 Update state is not changed to UPDAT...

Posted by bvbharatk <gi...@git.apache.org>.
Github user bvbharatk commented on the issue:

    https://github.com/apache/cloudstack/pull/1971
  
    @borisstoyanov 
    We do not have any unit tests for this, but we have rvr  marvin test, to test the basic functionality. 
    test/integration/component/maint/test_redundant_router.py .


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1971: CLOUDSTACK-9726 Update state is not changed to UPDAT...

Posted by blueorangutan <gi...@git.apache.org>.
Github user blueorangutan commented on the issue:

    https://github.com/apache/cloudstack/pull/1971
  
    @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1971: CLOUDSTACK-9726 Update state is not changed to UPDAT...

Posted by borisstoyanov <gi...@git.apache.org>.
Github user borisstoyanov commented on the issue:

    https://github.com/apache/cloudstack/pull/1971
  
    Thanks @bvbharatk, have you run any tests? If so, could you please share results?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1971: CLOUDSTACK-9726 Update state is not changed to UPDAT...

Posted by bvbharatk <gi...@git.apache.org>.
Github user bvbharatk commented on the issue:

    https://github.com/apache/cloudstack/pull/1971
  
     @borisstoyanov 
    I have only run BVTs, same as what you have already posted. Will also run the above mentioned test and post the results.
    thanks,
    Bharat.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---