You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/12/27 14:29:50 UTC

[GitHub] [incubator-superset] durchgedreht opened a new issue #8898: SQL Lab Query doesn't get reflected in chart

durchgedreht opened a new issue #8898: SQL Lab Query doesn't get reflected in chart
URL: https://github.com/apache/incubator-superset/issues/8898
 
 
   1. I go into SQL Lab and create a query. e.g. "SELECT * FROM data_table WHERE id > 10;"
   2. Then I do save the query.
   3. Clicking on 'run'.
   4. On the data view click on 'explore'
   5. Create a char with e.b. Bar Charts
   6. Save chart as "MyChart"
   
   THEN:
   
   1. Open saved query and change it. e.g. "SELECT * FROM data_table WHERE id >999"
   2. Save changed query
   3. Reopen Chart
   4. Data is same as before
   5. Chart datasource is something like "foo@bar.com --queryname-FYzgGs0CD" 
   
   ### Expected results
   
   I'd expect the chart reflects the changed query and doesn't do an 'in-time-smapshot'
   
   OR
   
   Another way to point to the 'original' query using a kind of pointer logic. 
   (By the way - changing a Datasource to SQLLab Query seems non supported as well)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] villebro commented on issue #8898: SQL Lab Query doesn't get reflected in chart

Posted by GitBox <gi...@apache.org>.
villebro commented on issue #8898: SQL Lab Query doesn't get reflected in chart
URL: https://github.com/apache/incubator-superset/issues/8898#issuecomment-569357800
 
 
   FYI I identified a bug (or more like an oversight) in the code that I've already fixed locally thanks to this ticket. Will do some more testing and put in PR in the coming days.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] durchgedreht commented on issue #8898: SQL Lab Query doesn't get reflected in chart

Posted by GitBox <gi...@apache.org>.
durchgedreht commented on issue #8898: SQL Lab Query doesn't get reflected in chart
URL: https://github.com/apache/incubator-superset/issues/8898#issuecomment-569358841
 
 
   Ok, cool! I'll keep an eye to the ticket so I will do some testing when done. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] durchgedreht commented on issue #8898: SQL Lab Query doesn't get reflected in chart

Posted by GitBox <gi...@apache.org>.
durchgedreht commented on issue #8898: SQL Lab Query doesn't get reflected in chart
URL: https://github.com/apache/incubator-superset/issues/8898#issuecomment-569357474
 
 
   To be more precise: I can edit the query in the data source view within the chart and can see the changes are not reflected. I'm wondering why every query should be immutable bound to a chart? This way it's pretty hard to do changes upon the same query. Fixing an error will result in n changes. This seems unwanted as changes in the other data sources are also reflected - so why should SQL queries underneath a chart behave differently?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] mistercrunch closed issue #8898: SQL Lab Query doesn't get reflected in chart

Posted by GitBox <gi...@apache.org>.
mistercrunch closed issue #8898: SQL Lab Query doesn't get reflected in chart
URL: https://github.com/apache/incubator-superset/issues/8898
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] durchgedreht commented on issue #8898: SQL Lab Query doesn't get reflected in chart

Posted by GitBox <gi...@apache.org>.
durchgedreht commented on issue #8898: SQL Lab Query doesn't get reflected in chart
URL: https://github.com/apache/incubator-superset/issues/8898#issuecomment-569287499
 
 
   No, I'm running against Clickhouse directly.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #8898: SQL Lab Query doesn't get reflected in chart

Posted by GitBox <gi...@apache.org>.
issue-label-bot[bot] commented on issue #8898: SQL Lab Query doesn't get reflected in chart
URL: https://github.com/apache/incubator-superset/issues/8898#issuecomment-569281056
 
 
   Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.91. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback! 
   
    Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] villebro commented on issue #8898: SQL Lab Query doesn't get reflected in chart

Posted by GitBox <gi...@apache.org>.
villebro commented on issue #8898: SQL Lab Query doesn't get reflected in chart
URL: https://github.com/apache/incubator-superset/issues/8898#issuecomment-569287279
 
 
   @durchgedreht are you using Redis to cache results?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] tcopple commented on issue #8898: SQL Lab Query doesn't get reflected in chart

Posted by GitBox <gi...@apache.org>.
tcopple commented on issue #8898: SQL Lab Query doesn't get reflected in chart
URL: https://github.com/apache/incubator-superset/issues/8898#issuecomment-569734759
 
 
   Is this a bug? I thought this was intentional. I agree it's frustrating but I just assumed the "derived" queries created from SqlLab were intentional.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org