You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/10/09 16:41:11 UTC
[GitHub] [skywalking] xu1009 opened a new pull request #7888: add kylin plugin component id
xu1009 opened a new pull request #7888:
URL: https://github.com/apache/skywalking/pull/7888
<!--
⚠️ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👇 ====
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👆 ==== -->
<!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/master/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== -->
<!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
- [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<7869>.
- [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/CHANGES.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xu1009 commented on a change in pull request #7888: add kylin plugin component id
Posted by GitBox <gi...@apache.org>.
xu1009 commented on a change in pull request #7888:
URL: https://github.com/apache/skywalking/pull/7888#discussion_r725765266
##########
File path: oap-server/server-starter/src/main/resources/component-libraries.yml
##########
@@ -392,6 +392,12 @@ ClickHouse-jdbc-driver:
ClickHouse:
id: 120
languages: Java
+Apache-kylin-jdbc-driver:
+ id: 121
+ languages: Java
+Apache-Kylin:
Review comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xu1009 commented on pull request #7888: add kylin plugin component id
Posted by GitBox <gi...@apache.org>.
xu1009 commented on pull request #7888:
URL: https://github.com/apache/skywalking/pull/7888#issuecomment-939653773
> You also miss the changes.md in the root.
sorry, i change this like other passed pr which only add component define, it looks some pr not add changes.md. hh, already ci
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #7888: add kylin plugin component id
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #7888:
URL: https://github.com/apache/skywalking/pull/7888#discussion_r725552485
##########
File path: oap-server/server-starter/src/main/resources/component-libraries.yml
##########
@@ -637,3 +640,4 @@ Component-Server-Mappings:
Psychopg: PostgreSQL
GoMysql: Mysql
ClickHouse-jdbc-driver: ClickHouse
+ Apache-kylin-jdbc-driver: Apache-kylin
Review comment:
And K should be upper case?
##########
File path: oap-server/server-starter/src/main/resources/component-libraries.yml
##########
@@ -637,3 +640,4 @@ Component-Server-Mappings:
Psychopg: PostgreSQL
GoMysql: Mysql
ClickHouse-jdbc-driver: ClickHouse
+ Apache-kylin-jdbc-driver: Apache-kylin
Review comment:
Where is the definition of apache-kylin? I think you missed this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #7888: add kylin plugin component id
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #7888:
URL: https://github.com/apache/skywalking/pull/7888#issuecomment-939649293
You also miss the changes.md in the root.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #7888: add kylin plugin component id
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #7888:
URL: https://github.com/apache/skywalking/pull/7888#discussion_r725761631
##########
File path: oap-server/server-starter/src/main/resources/component-libraries.yml
##########
@@ -392,6 +392,12 @@ ClickHouse-jdbc-driver:
ClickHouse:
id: 120
languages: Java
+Apache-kylin-jdbc-driver:
+ id: 121
+ languages: Java
+Apache-Kylin:
Review comment:
Please keep upper/lower case consistent about `kylin`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #7888: add kylin plugin component id
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #7888:
URL: https://github.com/apache/skywalking/pull/7888
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xu1009 commented on a change in pull request #7888: add kylin plugin component id
Posted by GitBox <gi...@apache.org>.
xu1009 commented on a change in pull request #7888:
URL: https://github.com/apache/skywalking/pull/7888#discussion_r725747058
##########
File path: oap-server/server-starter/src/main/resources/component-libraries.yml
##########
@@ -637,3 +640,4 @@ Component-Server-Mappings:
Psychopg: PostgreSQL
GoMysql: Mysql
ClickHouse-jdbc-driver: ClickHouse
+ Apache-kylin-jdbc-driver: Apache-kylin
Review comment:
ok, i recheck it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org