You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/02/14 13:06:15 UTC
[GitHub] [solr] dsmiley commented on a change in pull request #601: SOLR-15983: parallel log replay now uses separate UpdateRequestProcessor objects
dsmiley commented on a change in pull request #601:
URL: https://github.com/apache/solr/pull/601#discussion_r805822063
##########
File path: solr/core/src/java/org/apache/solr/update/UpdateLog.java
##########
@@ -2002,13 +2009,15 @@ public void doReplay(TransactionLog translog) {
translog.writeCommit(cmd);
}
- try {
- proc.finish();
- } catch (IOException ex) {
- recoveryInfo.errors.incrementAndGet();
- loglog.error("Replay exception: finish()", ex);
- } finally {
- IOUtils.closeQuietly(proc);
+ for (UpdateRequestProcessor proc : procPool) {
+ try {
+ proc.finish();
+ } catch (IOException ex) {
+ recoveryInfo.errors.incrementAndGet();
+ loglog.error("Replay exception: finish()", ex);
+ } finally {
+ IOUtils.closeQuietly(proc);
+ }
Review comment:
Nice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org