You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Henrique Mendonca (JIRA)" <ji...@apache.org> on 2012/06/22 14:04:43 UTC
[jira] [Comment Edited] (THRIFT-1353) Switch to performance branch,
get rid of BinaryParser
[ https://issues.apache.org/jira/browse/THRIFT-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399278#comment-13399278 ]
Henrique Mendonca edited comment on THRIFT-1353 at 6/22/12 12:04 PM:
---------------------------------------------------------------------
Here it is, finally.
THRIFT-1353-noBinaryParser-BufferedTrans-Int64-v3.patch
cleaned up and rebased for today's trunk
It also includes the files from node-int64
ps: the test from cpp client to nodejs server still fails but we're getting there...
ps2: rewriting the nodejs test client to use the assert module would be also nice...
ps3: patch with -p0 please
was (Author: henrique):
Here it is, finally.
THRIFT-1353-noBinaryParser-BufferedTrans-Int64-v3.patch
cleaned up and rebased for today's trunk
It also includes the files from node-int64
ps: the test from cpp client to nodejs server still fails but we're getting there...
ps2: rewriting the nodejs test client to use the assert module would be also nice...
> Switch to performance branch, get rid of BinaryParser
> -----------------------------------------------------
>
> Key: THRIFT-1353
> URL: https://issues.apache.org/jira/browse/THRIFT-1353
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Affects Versions: 0.7
> Reporter: Hans Duedal
> Assignee: Roger Meier
> Labels: node, nodejs
> Fix For: 1.0
>
> Attachments: THRIFT-1353-noBinaryParser-BufferedTrans-Int64-v3.patch
>
>
> I vote that the thrift library switches to the performance branch at https://github.com/wadey/node-thrift/tree/performance
> I much prefer using the node.js buffers over the BinaryParser class, the performance branch seems focused on this very issue. Also it includes the excellent int64 implementation from broofa. What's not to like?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira